calc(100% - 100px) break by minify - Githubissues

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.48k stars 9.29k forks source link

calc(100% - 100px) break by minify #12794

Closed larsroettig closed 6 years ago

larsroettig commented 6 years ago

Preconditions

Install Magento Open Source 2.2 or 2.3dev
This branches use tubalmartin/cssmin 2.4.8-p4

Steps to reproduce

Define calc(100% - 100px)in stylesheet
Active css minify

Expected result

In css.min is definedcalc(100% - 100px)

Actual result

In css.min is definedcalc(100%-100px)
It is not allowed to remove whitespaces before and after - breaks the stylesheet

Possible Solution

Update to version 4.1 see: https://github.com/larsroettig/magento2_css_min_fix/blob/master/test.css.min
https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port#6-changelog has many bugfixes and performance improvements

Info

https://www.w3schools.com/cssref/func_calc.asp

sydekumf commented 6 years ago

Duplicate of: https://github.com/magento/magento2/issues/8552