Track not saved during shipment creation through API

[siimm]

Preconditions

1. Magento CE 2.2.3 with sample data installed (Also same in CE 2.2.2)
2. PHP 7.0.22

Steps to reproduce

1. Create an order with one item
2. Use Magento REST API to create a shipment (POST rest/V1/shipment/) Request body: { "entity":{ "order_id":3, "items": [ { "order_item_id": 3, "qty": 1 } ], "comments": [ { "is_customer_notified": 1, "comment" : "this is a comment for order #3" } ], "tracks": [ { "track_number": "2Y-987651110", "title": "United Parcel Service", "carrier_code": "ups", "order_id":3, "extension_attributes" : {} } ] } } Request with better formatting as a gist: https://gist.github.com/siimm/d4f2f6644e0d1255cbe4339bb42084e2

Expected result

1. A shipment is created with a comment added and tracking attached

Actual result

1. Shipment is created with comment added but without any tracking number attached

General background:

Upon saving the shipment relations in Magento\Sales\Model\ResourceModel\Order\Shipment\Relation::processRelation() $object->getTracksCollection() is consulted, while during the API request $object->setTracks() is used and it is not set as a collection

As a solution getTracks() should also be processed in Relation class, or the tacks should be added using addTarck() method on Shipping model (which initialises the collection of tracks)

[magento-engcom-team]

@siimm, thank you for your report. We've acknowledged the issue and added to our backlog.

[arijit-de93]

I am working on this at #dmcdindia

[michaelbakertup]

Does anyone know if this is fixed in 2.2.6 ?

[mirkocesaro]

Does anyone know if this is fixed in 2.2.6 ?

@michaelbakertup the issue is still there

[mam08ixo]

AFAIK the preferred endpoint for creating shipments is POST /V1/order/{orderId}/ship.

[m2-assistant[bot]]

Hi @engcom-Alfa. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Alfa]

Hi @siimm. We are not able to reproduce this issue on fresh 2.4-develop instance. Everything works correctly.

Manual testing scenario:

1. Create an order with one item ("order_id":1, order_item_id": 1) for ex.;
2. Use Magento REST API to create a shipment (POST rest/V1/shipment/) Request body: { "entity":{ "order_id":3, "items": [ { "order_item_id": 3, "qty": 1 } ], "comments": [ { "is_customer_notified": 1, "comment" : "this is a comment for order #3" } ], "tracks": [ { "track_number": "2Y-987651110", "title": "United Parcel Service", "carrier_code": "ups", "order_id":3, "extension_attributes" : {} } ] } }

Actual Result:

A shipment is created with a comment added and tracking attached

So, we have to close it. Please feel free to comment, reopen or create new ticket according to the Issue reporting guidelines if you are still facing this issue on the latest 2.4-develop branch. Thank you for collaboration.