search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

Change zip code validation pattern for Japan #14072

Closed HirokazuNishi closed 6 years ago

HirokazuNishi commented 6 years ago

Preconditions

  1. magento 2.3.x
  2. magento 2.2.x
  3. magento 2.1.x
  4. magento 2.0.x

Steps to reproduce

  1. Add one more item into cart
  2. Proceed checkout step
  3. Choose "Japan" for country
  4. Set zip code like "123" or "123-4567"
  5. If you set other pattern, you may get validation error message.

Expected result

  1. "1234567" or "123-4567" only can pass the validation. Since 1998, Japanese postoffice only uses 7 digits for zipcode.

Actual result

  1. 123 is not a valid pattern, but actually recognized as a valid pattern. 7 digits of number should be allowed instead of existing pattern_2.
magento-engcom-team commented 6 years ago

@HirokazuNishi , thank you for your report. We've acknowledged the issue and added to our backlog.

osrecio commented 6 years ago

Working on it #distributed-cd

magento-engcom-team commented 6 years ago

@osrecio thank you for joining. Please accept team invitation here and self-assign the issue.

magento-engcom-team commented 6 years ago

Hi @HirokazuNishi. Thank you for your report. The issue has been fixed in magento/magento2#14300 by @osrecio in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team commented 6 years ago

Hi @HirokazuNishi. Thank you for your report. The issue has been fixed in magento/magento2#14299 by @osrecio in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming 2.2.5 release.