magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

Custom Payment Method doesn't uncheck 'My billing and shipping address are the same' #14819

Closed eduard13 closed 6 years ago

eduard13 commented 6 years ago

In Magento 2.2.2, 2.2.3 there is no way to get the Magento behavior on My billing and shipping address are the same checkbox when a new custom Offline Payment Method is used.

Preconditions

  1. Magento 2.2.3 EE (on Magento 2.2.2 CE as well)
  2. PHP 7.1

Steps to reproduce

  1. Create an offline payment method
  2. Add a product to cart
  3. Go to Checkout
  4. Fill in the shipping address
  5. Go to Payment Step
  6. We have our new payment method, and one more - Checkmo
  7. Select Checkmo
  8. Under Selected Payment Method - My billing and shipping address are the same is checked and below we have the billing address = shipping address 4d0833cc22
  9. Go back to shipping step and change some fields
  10. Come back on the Payment Step

Expected result

  1. My billing and shipping address are the same it should be unchecked 20e4fedd4b

Actual result

  1. My billing and shipping address are the same is checked, but the address information below doesn't reflect the last changes. a67191078b

Also noticed that if the Custom Payment Method is marked as Unavailable, then everything works as needed

Thanks.

ghost commented 6 years ago

HI @eduard13 thank you for your report. We've acknowledged the issue and added to our backlog.

eduard13 commented 6 years ago

I'm going to work on it.

magento-engcom-team commented 6 years ago

Hi @eduard13. Thank you for your report. The issue has been fixed in magento/magento2#17593 by @eduard13 in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

magento-engcom-team commented 6 years ago

Hi @eduard13. Thank you for your report. The issue has been fixed in magento/magento2#17628 by @jignesh-baldha in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

miteshdhaduk commented 5 years ago

@jignesh-baldha Thank you for fixing this. It is working properly in Magento 2.2.