magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

First line of theme translation file is ignored for some languages #16490

Closed denistrator closed 1 month ago

denistrator commented 6 years ago

Summary

First line of theme translation file (app/design/frontend/Vendor/Theme/i18n/xx_XX.csv) is ignored for some languages. Tested for en_US, he_IL, fr_BE and ru_RU. en_US works as expected, but he_IL, fr_BE and ru_RU don't.

Preconditions

  1. Magento 2.2.4

Steps to reproduce

  1. Create FE theme with he_IL (Hebrew) locale. Apply it
  2. Create i18n/he_IL.csv translation file in theme you created
  3. Add translation in the file you created. For example: "Add to Wish List","TEST he_IL Add to Wish List TEST" "Add to Compare","TEST he_IL Add to Compare TEST"
  4. Open any product page

Expected result

  1. All the phrases from i18n/xx_XX.csv are translated

Actual result

  1. All the phrases from i18n/xx_XX.csv except first one are translated

Additional info

See .csv files and FE product page screenshots for: en_US he_IL fr_BE

magento-engcom-team commented 6 years ago

Hi @denistrator. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +). For more details, please, review the Magento Contributor Assistant documentation.

@denistrator do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

engcom-backlog-nickolas commented 6 years ago

@denistrator, thank you for your report. Unfortunately I'm not able to reproduce this issue with given steps: fr_fr he_il Can you please provide more details?

denistrator commented 6 years ago

@engcom-backlog-nickolas did you test it on Magento 2.2.4?

engcom-backlog-nickolas commented 6 years ago

@denistrator, yes. I've tried to reproduce it on 2.2.4, 2.2.5 and 2.3.0

denistrator commented 6 years ago

@engcom-backlog-nickolas I've tested it again on just installed M2.2.4. https://www.youtube.com/watch?v=wOv10BJFAXA

engcom-backlog-nickolas commented 6 years ago

@denistrator, thanks for help, much appreciated. We've acknowledged the issue and added to our backlog.

magento-engcom-team commented 5 years ago

Hi @niravkrish. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

magento-engcom-team commented 5 years ago

Hi @hiren0241. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

mrtuvn commented 3 years ago

Screenshot from 2021-03-26 18-37-48 works fine in my local with 2.4-develop github branch cc: @denistrator

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1038 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

engcom-Bravo commented 1 month ago

@mrtuvn Thanks for your contribution!!.

As per this comment https://github.com/magento/magento2/issues/16490#issuecomment-808148353 the issue was working fine in Latest 2.4-develop branch.

Hence we are closing this issue.

Thanks.