magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

Magento 2.2.5 Temando_Shipping messing up Multi Shipping again #17062

Closed dyuk1987 closed 6 years ago

dyuk1987 commented 6 years ago

Preconditions

  1. Magento CE 2.2.5 without demo data
  2. Temando_Shipping module enabled by default but not configured and enabled as a shipping method
  3. Allow Shipping to Multiple Addresses is enabled
  4. A few simple products are created
  5. Amazon_Core, Klarna_Core, Amazon_Login, Amazon_Payment, Klarna_Ordermanagement, Klarna_Kp are disabled

Steps to reproduce

  1. Register as a user
  2. Add at least 2 shipping addresses
  3. Add a few products to the cart
  4. Proceed to shopping cart and checkout with multiple shipping addresses
  5. Finish the checkout procedures.
  6. Try to view the completed order.
  7. The following error appears:

    Exception #0 (Exception): Notice: Undefined offset: 1 in /xxxxxxxxxxxxxx/vendor/magento/module-sales/Model/Order.php on line 1205

    0 /xxxxxxxxxxxxxx/vendor/magento/module-sales/Model/Order.php(1205): Magento\Framework\App\ErrorHandler->handler(8, 'Undefined offse...', '/home/admin/web...', 1205, Array)

    1 /xxxxxxxxxxxxxx/vendor/temando/module-shipping-m2/Observer/PrepareMyOrderInfoObserver.php(70): Magento\Sales\Model\Order->getShippingMethod(true)

    (...)

The same happened when I try to view the order from the admin panel.

Expected result

Details of the order should be shown properly.

Actual result

Errors occurred and the page could not be reached.

Other observations

  1. When the Temando_Shipping module is disabled, the error goes away.
  2. I am not sure if it has anything to do with the issues in #16104.
magento-engcom-team commented 6 years ago

Hi @dyuk1987. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +). For more details, please, review the Magento Contributor Assistant documentation.

@dyuk1987 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

magento-engcom-team commented 6 years ago

Hi @denisflosi1. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

marcelo-monteiro commented 6 years ago

Hi @dyuk1987 Like @okorshenko replied, in #17131, this issue is caused by a vendor extension. Please contact the vendor support team for the assistance: https://developer.temando.com/soap/index.html or email them tsupport@temando.com