magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

"- undefined" displayed in checkout summary when shipping method name is not set #17492

Closed krzksz closed 5 years ago

krzksz commented 6 years ago

Sometimes it is the case that setting both Carrier title and Method name for a shipping method is redundant and having only the first one set it totally enough. Sadly, in the case of leaving Method name field blank there is a small visual bug displayed in checkout summary box.

Preconditions

  1. Magento 2.2.x, but any version may be affected
  2. Shipping method with empty Method Name set.

Steps to reproduce

  1. Add new or edit any existing shipping methods with Method name field left as a blank field.
  2. Add any product to the cart and go through the checkout to the last step.

Expected result

  1. Shipping method is displayed nicely.

Actual result

  1. There is a - undefined string displayed. obraz
magento-engcom-team commented 6 years ago

Hi @krzksz. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +). For more details, please, review the Magento Contributor Assistant documentation.

@krzksz do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

krzksz commented 6 years ago

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team commented 6 years ago

Hi @krzksz. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team commented 6 years ago

Hi @krzksz, here is your Magento instance. Admin access: https://i-17492-2-2-develop.engcom.dev.magento.com/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

ghost commented 6 years ago

@krzksz , thank you for your report. We've acknowledged the issue and added to our backlog.

magento-engcom-team commented 6 years ago

Hi @krzksz. Thank you for your report. The issue has been fixed in magento/magento2#17526 by @gelanivishal in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

magento-engcom-team commented 6 years ago

Hi @krzksz. Thank you for your report. The issue has been fixed in magento/magento2#17697 by @gelanivishal in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

orlangur commented 5 years ago

This seems to be not fixed completely according to new linked PR.

m2-assistant[bot] commented 5 years ago

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @engcom-Alfa Thank you for verifying the issue. Based on the provided information internal tickets MC-17845, MC-17846 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team commented 5 years ago

Hi @krzksz.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.2.10 release.

magento-engcom-team commented 5 years ago

Hi @krzksz.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.3 release.