magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.43k stars 9.29k forks source link

Client side less compilation not working #19115

Closed torhoehn closed 5 years ago

torhoehn commented 5 years ago

Preconditions (*)

  1. Magento ver. 2.3.0-beta23
  2. PHP 7.1.22

Steps to reproduce (*)

  1. Set Magento into developer mode
  2. Login into Backend and navigate to Stores -> Configuration -> Advanced -> Developer -> Frontend Development Workflow
  3. Set Workflow type to Client side less compilation
  4. Load Storefront

Expected result (*)

  1. Theme should be rendered correctly

Actual result (*)

  1. SyntaxError: Cannot set property 'important' of undefined in styles-m.css screenshot 2018-11-08 at 10 24 36
magento-engcom-team commented 5 years ago

Hi @torhoehn. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop). For more details, please, review the Magento Contributor Assistant documentation.

@torhoehn do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

torhoehn commented 5 years ago

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @torhoehn. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @torhoehn, here is your Magento instance. Admin access: http://34.228.235.121/i-19115-2-3-develop//admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

Hi @engcom-backlog-nazar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

torhoehn commented 5 years ago

@magento-engcom-team Unfortunately it's working vanilla Magento instance.

ghost commented 5 years ago

Hi @torhoehn seem like this already fixed in 2.3-dev branch, i'm also cannot reproduce on 2.3-dev. If you like to update this please reopen the issue.

torhoehn commented 5 years ago

@engcom-backlog-nazar Do you know if something has changed or an idea where I have to search for that? So I would be able to apply a fix manually in our project.

ghost commented 5 years ago

@torhoehn Sorry i'm can't find where this was fixed, i was try search in history commits, but not found any related commits

torhoehn commented 5 years ago

@engcom-backlog-nazar We updated to Magento ver. 2.3.0-beta32. Now it's working again.