Magento 2.2.6 Update Removes Manufacturer Attribute from Product Edit Page

nickpiro commented 5 years ago

Preconditions

Magento 2.2.5 - Manufacturer Attribute visible in product edit page on Magento backend!

Steps to reproduce

Upgrade to Magento 2.2.6

Expected result

Manufacturer attribute still visible in product edit page on Magento backend!

Actual result

No Manufacturer attribute on product edit page on Magento backend!

manufacturer attribute is visible in Attribute Set edit page under Attributes folder
manufacturer attribute and all information is still on the Product Attribute edit page for manufacturer
manufacturer still visible on product page - Manufacturer Attribute is visible on Configurable Page Only
Manufacturer Attribute is not visible on Simple, Grouped, Bundle, Virtual and Downloadable Products

magento-engcom-team commented 5 years ago

Hi @nickpiro. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop). For more details, please, review the Magento Contributor Assistant documentation.

@nickpiro do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

magento-engcom-team commented 5 years ago

Hi @TomashKhamlai. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
[ ] 6. Add label Issue: Confirmed once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

TomashKhamlai commented 5 years ago

@magento-engcom-team give me 2.2.5 instance

magento-engcom-team commented 5 years ago

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2.5 instance for you

magento-engcom-team commented 5 years ago

Hi @TomashKhamlai, here is your Magento instance. Admin access: https://i-19716-2-2-5.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

TomashKhamlai commented 5 years ago

@magento-engcom-team give me 2.2.6 instance

magento-engcom-team commented 5 years ago

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2.6 instance for you

magento-engcom-team commented 5 years ago

Hi @TomashKhamlai, here is your Magento instance. Admin access: https://i-19716-2-2-6.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

TomashKhamlai commented 5 years ago

I cannot reproduce this issue.

Steps to reproduce:

Get Magento Metapackage composer create-project --repository=https://repo.magento.com/ magento/project-community-edition:2.2.5 .

Install Magento. I prefer to do this from the CLI:

php bin/magento setup:install --backend-frontname="admin" --db-host="127.0.0.1" --db-name="magento225" --db-user="root" --admin-user="admin" --admin-password="123123q" --admin-email="earthworm.jim@gmail.com" --admin-firstname="Jim" --admin-lastname="Earthworm" --base-url="http://magento-composer.loc/" --cleanup-database --use-rewrites 1 && php bin/magento indexer:reindex && php bin/magento cache:flush

Login to Admin
Navigate to Stores > Attributes > Product
Add 2 options to the attribute
Navigate to Stores > Attributes > Attribute Set
Modify Default attribute set to have manufacturer attribute saved in the Default attribute set
Create new attribute set based on Default
Perform required operations: php bin/magento indexer:reindex php bin/magento cache:flush
Create 1 Simple and 1 Configurable product per attribute set.

Let uninstall some bundles because of #18248. Also bundles are not listed in this repository. Composer documentation has good article about this https://getcomposer.org/doc/04-schema.md#replace

"replace": {
    "temando/module-shipping-m2": "*",
    "dotmailer/dotmailer-magento2-extension": "*",
    "shopialfb/facebook-module": "*",
    "klarna/module-kp": "*",
    "klarna/module-ordermanagement": "*",
    "klarna/module-core": "*",
    "amzn/amazon-pay-sdk-php": "*",
    "amzn/amazon-pay-and-login-with-amazon-core-module": "*",
    "amzn/login-with-amazon-module": "*",
    "amzn/amazon-pay-module": "*",
    "vertex/module-tax": "*"
},

For example:

...
        "Magento\\TestFramework\\Utility\\": "dev/tests/static/framework/Magento/TestFramework/Utility/"
    }
},
"minimum-stability": "stable",
"replace": {
    "temando/module-shipping-m2": "*",
    "dotmailer/dotmailer-magento2-extension": "*",
    "shopialfb/facebook-module": "*",
    "klarna/module-kp": "*",
    "klarna/module-ordermanagement": "*",
    "klarna/module-core": "*",
    "amzn/amazon-pay-sdk-php": "*",
    "amzn/amazon-pay-and-login-with-amazon-core-module": "*",
    "amzn/login-with-amazon-module": "*",
    "amzn/amazon-pay-module": "*",
    "vertex/module-tax": "*"
},
"repositories": [
    {
        "type": "composer",
...

Do composer update && php bin/magento setup:upgrade
Login to Admin
Go to System > Tools > Web Setup Wizard
Upgrade to Magento 2.2.6.
Login to Admin
Check the products

nickpiro commented 5 years ago

This shouldn't be closed. I installed a vanilla version of 2.2.5 and upgraded to 2.2.6 and also had the error.

TomashKhamlai commented 5 years ago

@nickpiro please, add more details or try to follow my steps. I am asking for more details because there is an issue with bundle extensions while upgrading from this version. At least I do not know the way you managed to work with this issue. Also I should identify that the problem comes from Magento and not from one of the bundled extensions. Will you add more information?

TomashKhamlai commented 5 years ago

As I can see you already know about #18134. It is hard to imagine that there is a problem that one cannot upgrade because of an attribute and other get Magento upgraded but an attribute doesn't exist after upgrade.

BrockleyJohn commented 5 years ago

Anyone got a workaround? Client has a newly acquired 2.2.6 store and can't edit the manufacturer attribute on newly added products, while ones that were created before upgrade are populated.

Edit: it's here: https://github.com/magento/magento2/issues/18134#issuecomment-427341783

hostep commented 5 years ago

@BrockleyJohn points to the correct comment(s) indeed.

But this isn't a bug as far as I can see.

I just did some testing, with Magento 2.2.5, the apply_to column for the manufacturer attribute in the catalog_eav_attribute table in the database only has the value simple.

After upgrading to Magento 2.2.6, the apply_to value becomes simple,configurable.

If somehow this apply_to column got invalid values (where simple is missing somehow - not sure how this can happen though), you'd best manually fix that value directly in the database or using some upgrade script.

nickpiro commented 5 years ago

This is still an issue in 2.2.8. We just upgraded from 2.2.5 to 2.2.8 on our live site and now Manufacturer is missing!

hostep commented 5 years ago

@nickpiro: can you check your database and make sure the apply_to value for the manufacturer attribute in the catalog_eav_attribute table is set to simple,configurable (or all the product types you want it to be visible on)? If I have to guess it's probably set to something incorrect in your case. You can find the attribute_id of the manufacturer attribute in the eav_attribute table btw.

arrowgr commented 5 years ago

The database is the solution catalog_eav_attribute add this simple,configurable from configurable

adarshkhatri commented 4 years ago

Any reason it was made available only for simple and configurable products? We do have some bundle items that are from the same manufacturer and can be sold individually as well as bundled.

The main problem I have now is with my old data. When I migrated 1.9 to 2.3, I have bundle products with manufacturer data in it and they are showing fine, but now I cannot change them.

stephansteiner commented 3 years ago

Any reason it was made available only for simple and configurable products? We do have some bundle items that are from the same manufacturer and can be sold individually as well as bundled.

The main problem I have now is with my old data. When I migrated 1.9 to 2.3, I have bundle products with manufacturer data in it and they are showing fine, but now I cannot change them.

I ran into the same issue, having bundles consisting of products from the same manufacturer. The fix is to either add "bundle" to the list of values in "apply_to" or to set apply_to to NULL (so it can be assigned to any product type). First, find out the attribute id by searching in the database for: select attribute_id from eav_attribute where attribute_code='manufacturer';

Then, do an update to the table catalog_eav_attribute: update catalog_eav_attribute set apply_to=NULL where attribute_id=<put id from above>; After that, reindex and clear caches and the attribute will appear in the backend when editing a bundle product.

However, I'm wondering why there is no admin configuration possibility to change apply_to as there was in Magento1.

magento / magento2