Cart Items are deleted after fail checkout magento2.2.1

[devmag1]

Preconditions (*)

1. Magento v2.2.1
2. Products should be added in the cart
3. Payment Gateway that accepts online transaction

Steps to reproduce (*)

1. Add products to cart
2. Go to the checkout page
3. Fill out all the information
4. let's say I select PayUMoney payment gateway
5. Next, I click PLACE ORDER button (on click of this button the order gets placed as pending in the Magento 2 backend)
6. A popup opens asking me to enter credit card details
7. If I close the popup the cart/checkout is empty and there are no products that I had selected

Expected result (*)

1. On PLACE ORDER button click, the order should not get placed in the Magento Backend.
2. On Succesful payment only, the order should get placed in the Magento backend
3. If I cancel/fail the order, then cart items should not get cleared and I should be able to checkout again with another payment option.

Actual result (*)

1. The order is placed on the backend as pending in Magento 2 backend irrespective of successful or failed payment.
2. If I cancel/fail the payment, the cart items should not get cleared and I should be able to reorder again through another or same payment gateway.

[magento-engcom-team]

Hi @devmag1. Thank you for your report. To help us process this issue please make sure that you provided the following information:

• [ ] Summary of the issue
• [ ] Information on your environment
• [ ] Steps to reproduce
• [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop). For more details, please, review the Magento Contributor Assistant documentation.

@devmag1 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [ ] yes
• [ ] no

[magento-engcom-team]

Hi @engcom-backlog-andrii. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• [ ] 6. Add label Issue: Confirmed once verification is complete.

• [ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

[ghost]

Hi @devmag1 Thanks for the report, i'm not able to reproduce following steps your described.

[devmag1]

@engcom-backlog-andrii

Summary of the issue(*)

When I try to place an order with all the required information filled in and choose the mode of payment as PayUmoney payment Gateway then post click of Place order button, it redirects me to Payumoney popup. If I cancel the transaction on reaching this stage then in Magento Admin Panel it shows in ordered list with the order payment status as"pending payment"which should not be the case. Instead it should show cancelled status without affecting the inventory.

Information environment (*)

1. magento version 2.2.1
2. payment getway module : PayUmoney
3. checkout module : magestore onestep checkout

Steps to reproduce (*)

1. Add products to cart
2. Go to the checkout page
3. Fill out all the information
4. let's say I select PayUMoney payment gateway
5. Next, I click PLACE ORDER button (on click of this button the order gets placed as pending in the Magento 2 backend)
6. A popup opens asking me to enter credit card details
7. If I close the popup the cart/checkout is empty and there are no products that I had selected

Expected results (*)

1. On PLACE ORDER button click, the order should not get placed in the Magento Backend.
2. On Succesful payment only, the order should get placed in the Magento backend
3. If I cancel/fail the order, then cart items should not get cleared and I should be able to checkout again with another payment option.

Actual results (*)

1. The order is placed on the backend as pending in Magento 2 backend irrespective of successful or failed payment.
2. If I cancel/fail the payment, the cart items should not get cleared and I should be able to reorder again through another or same payment gateway.

[chittik27]

Please override Failure.php and change change Public Function as below in magento 2.3.5,

` public function execute() {

    $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
    $_checkoutSession = $objectManager->create('\Magento\Checkout\Model\Session');
    $_quoteFactory = $objectManager->create('\Magento\Quote\Model\QuoteFactory');

    $order = $_checkoutSession->getLastRealOrder();
    $quote = $_quoteFactory->create()->loadByIdWithoutStore($order->getQuoteId());
    if ($quote->getId()) {
        $quote->setIsActive(1)->setReservedOrderId(null)->save();
        $_checkoutSession->replaceQuote($quote);
        $resultRedirect = $this->resultRedirectFactory->create();
        $resultRedirect->setPath('checkout/cart');
        //$this->messageManager->addWarningMessage('Payment Failed.');
        return $resultRedirect;
    }
}`