magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

View and Edit Cart link not aligned in middle because bellow the link a blank div (class="minicart-widgets") existing has 15px margin top, this div (class="minicart-widgets" ) should be display none or should not come if has no content, should only display if has content #20382

Closed irajneeshgupta closed 5 years ago

irajneeshgupta commented 5 years ago

View and Edit Cart link not aligned in middle because bellow the link a blank div (class="minicart-widgets") existing has 15px margin top, this div (class="minicart-widgets" ) should be display none or should not come if has no content, should only display if has content.

Preconditions (*)

  1. Magento 2.3
  2. php 7.2

Steps to reproduce (*)

  1. Open frontend
  2. Add any product in cart and go to minicart and see View and Edit Cart Link (you will get issue )
  3. you will see extra space bellow the link and now inspect you see bank div has 15px margin top.

Expected result (*)

mini_sol

Actual result (*)

mini_issue

magento-engcom-team commented 5 years ago

Hi @irajneeshgupta. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop). For more details, please, review the Magento Contributor Assistant documentation.

@irajneeshgupta do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

magento-engcom-team commented 5 years ago

Hi @cedarvinda. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

cedarvinda commented 5 years ago

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @cedarvinda. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @cedarvinda, here is your Magento instance. Admin access: https://i-20382-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

@cedarvinda Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97700 were created

cedarvinda commented 5 years ago

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team commented 5 years ago

Hi @cedarvinda. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team commented 5 years ago

Hi @cedarvinda, here is your Magento instance. Admin access: https://i-20382-2-2-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

Hi @irajneeshgupta. Thank you for your report. The issue has been fixed in magento/magento2#20383 by @irajneeshgupta in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

magento-engcom-team commented 5 years ago

Hi @irajneeshgupta. Thank you for your report. The issue has been fixed in magento/magento2#21124 by @irajneeshgupta in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

kozie commented 5 years ago

@irajneeshgupta Why did you add an if statement to the following line?https://github.com/magento/magento2/blob/f77ac3c8ce55a52be143f18073106c5de68adc35/app/code/Magento/Checkout/view/frontend/web/template/minicart/content.html#L100 It doens't make sense seeing the current issue and it's causing my widgets to not show up anymore.