magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

Custom select attribute code "container" breaks javascript on update attributes #21232

Open cralls opened 5 years ago

cralls commented 5 years ago

Preconditions (*)

  1. Magneto 2.2.3
  2. PHP 7.0.33

Steps to reproduce (*)

  1. Create a custom select attribute with a code of "container"
  2. Go to the Catalog->Products and check the box next to at least one product.
  3. Click the Action dropdown and select "Update Attributes"
  4. Scroll down until you see your container attribute and you will see that it is not disabled

Expected result (*)

  1. The attribute should be disabled by default until you check the Change box

Actual result (*)

  1. The container attribute is enabled and if you check the Change checkbox on/off nothing happens image

Workaround (*)

Edit eav_attribute table and change the attribute code from "container" to something else. The problem happens because there is already a css id "container" on the page and this breaks the javascript function to enable/disable your custom attribute with the same name "container"

magento-engcom-team commented 5 years ago

Hi @cralls. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@cralls do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

magento-engcom-team commented 5 years ago

Hi @shikhamis11. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

shikhamis11 commented 5 years ago

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @shikhamis11, here is your Magento instance. Admin access: https://i-21232-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

shikhamis11 commented 5 years ago

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team commented 5 years ago

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team commented 5 years ago

Hi @shikhamis11, here is your Magento instance. Admin access: https://i-21232-2-2-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @shikhamis11 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98277, MAGETWO-98278 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team commented 5 years ago

Hi @m-a-x-i-m. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

engcom-Bravo commented 4 months ago

Hi @cralls,

Thanks for your reporting and collaboration.

Verified the issue in Latest 2.4-develop instance and the issue is reproducible.

Screenshot 2024-05-06 at 16 58 33

The container attribute is enabled and if you check the Change checkbox on/off nothing happens

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 4 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11908 is successfully created for this GitHub issue.

m2-assistant[bot] commented 4 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 4 months ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11908