magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.59k stars 9.32k forks source link

2.3 - WYSIWYG Editor removes <i> tag #21602

Closed Rueff19 closed 5 years ago

Rueff19 commented 5 years ago

Preconditions (*)

  1. Magento ver 2.3.0
  2. PHP 7.2.15
  3. Ubuntu 18.04.1

Steps to reproduce (*)

  1. Content -> Pages -> Show or hide wysiwg editor -> Insert tag anywhere. Inside elements or on it's own.

Expected result (*)

wysiwyg_editor_error_1

Actual result (*)

wysiwyg_editor_error_2

magento-engcom-team commented 5 years ago

Hi @Rueff19. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Rueff19 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

Rueff19 commented 5 years ago

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @Rueff19. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @Rueff19, here is your Magento instance. Admin access: https://i-21602-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

Hi @Rueff19. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @Rueff19, here is your Magento instance. Admin access: https://i-21602-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

abrarpathan19 commented 5 years ago

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @abrarpathan19. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @abrarpathan19. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 5 years ago

Hi @abrarpathan19, here is your Magento instance. Admin access: https://i-21602-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

Hi @engcom-backlog-nazar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

ghost commented 5 years ago

Hi @Rueff19 Yes, TinyMCE treats all empty elements that don't have meaning in html as empty space, same as browsers treat them. <span></span>, <div></div>, even <p></p>are not displayed in the browser. If they have any attributes, they are not removed.

ghost commented 5 years ago

@Rueff19 work around The second, more stable solution was to use a html comment tag, this doesn’t have the side effect of visually outputting any extra markup as per the previous option.

<i class="fa fa-gamepad"><!-- icon --></i>

Rueff19 commented 5 years ago

@engcom-backlog-nazar Thank you, as ver 2.2 allows it I thought it was something more complicated. Thanks for the quick reply and work arround.

Rueff19 commented 5 years ago

@engcom-backlog-nazar With the <!-- Icon -->, another thing is that it now changes the <i> tag to <em>. In this case it doesn't affect the outcome but might be something worth looking into.

ghost commented 5 years ago

@Rueff19 https://github.com/tinymce/tinymce/issues/2689#issuecomment-391686340

avoelkl commented 4 years ago

Is there any update or workarund to this? We just encountered this issue with one of our merchants.

<!-- Icon --> updates the <i> element to <em> as mention in the comment above...

Jojohomefries commented 4 years ago

Why is this issue closed, it is still happening

LiamKarlMitchell commented 4 years ago

Reopen please.