Open kanduvisla opened 5 years ago
Hi @kanduvisla. Thank you for your report. To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento-engcom-team give me 2.3-develop instance
- upcoming 2.3.x release
For more details, please, review the Magento Contributor Assistant documentation.
@kanduvisla do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
Hi @engcom-backlog-nazar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop
branchDetails
- Add the comment @magento-engcom-team give me 2.3-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop
branch, please, add the label Reproduced on 2.3.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Verify that the issue is reproducible on 2.2-develop
branch. Details
- Add the comment @magento-engcom-team give me 2.2-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop
branch, please add the label Reproduced on 2.2.x
Next steps are available in case you are a member of Community Maintainers.
[ ] 6. Add label Issue: Confirmed
once verification is complete.
[ ] 7. Make sure that automatic system confirms that report has been added to the backlog.
Hi @kanduvisla thank you for your report. is there any additional steps to reproduce this issue ?
@engcom-backlog-nazar I'm trying to figure out what goes wrong. I have multiple Magento 2 installations, but this only affects one. That makes it so strange.
I am currently researching the session handlers. The weird part is (on a vanilla installation) that when writeClose()
is called, the checkout session is empty, but as soon as (on a new request) the session_start()
is called, the checkout session is repopulated. But this seems to be the part that is not working in my other setup.
At first tests it seems that disabling the persistent cart module caused this issue. I'll check if re-enabling it solves it.
I re-enabled the module and it seems that that solves the issue. So that makes this issue reproducible (already tested it on a vanilla installation):
Magento_Persistent
module?foo=bar
) so it misses the cacheI'll update this issue.
@engcom-backlog-nazar : is this a bug or a feature? It looks like that if you disable the Magento_Persistent
-module the FPC will flush your checkout session as soon as it misses a cache.
:white_check_mark: Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98649
, MAGETWO-98650
were created
Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Hi @magento - Is there an update on this one? We are having this issue on a number of sites
So @magento-engcom-team when we are supposed to get the re-solved version of magento.
@magento-engcom-team please can you provide an update, we have multiple clients with this issue
@magento-engcom-team I Have a problem when FPC is enable on my M2 2.3. The problem is when I add a product to the cart and then goes to another category. then the cart willl be empty. When FPC is disable all works fine.
Hi @magento-engcom-team any news on this issue?
Also running against this problem with Magento 2.3.1 and 2.3.2, enabling the Persistent module again fixes it over here.
Also, this is probably a duplicate of https://github.com/magento/magento2/issues/17973 although this issue here has much better information.
@magento-engcom-team The 2.3.3 release notes say that:
Full-page cache no longer clears out the checkout session data on uncached pages when the
Magento_Persistent
module is disabled. GitHub-21614
If this indeed the case, can you provide a link to the commit that fixed this issue and then close this issue and issue #17973?
@magento-engcom-team I'm running on Magento Open Source 2.3.3-p1 and I'm still able to reproduce this issue. Can you post a link to the commit where this was purportedly fixed?
@magento-engcom-team I am running on Magento Enterprise 2.3.2(with Magento_Persistent enabled) and I am able to reproduce the issue. When quickly adding consecutive items to cart via AJAX quote is dropped after first addition, new one created and assigned, then the old one is added back again with the third or fourth addition, and sometimes it just keeps jumping from one to another
:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1034 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
What is the resolution for this issue? ✅ Jira issue https://jira.corp.magento.com/browse/AC-1034 is successfully created for this GitHub issue. Without jira access how can one determine the status of the issue? I am having the same problem in 2.4.3 and 2.4.5p1 where the session is cleared when the PlaceOrder controller executes. This causes a failure in checkout after a successful cybersource payment authorization. Thanks for your attention.
Hello @adammberk,
We will update you here on this issue when the fix will be fixed and merged with the development branch.
Thanks
@engcom-Hotel I wanted to add to my comment that I have put debugging statements into the Depersonalize class. What I am observing is that the session is being cleared in PlaceOrder and Success controllers whether or not the Magento_Persistent module is enabled or disabled and whether of not the depersonalize flag is set to true or false as shown in this debug statement:
report.DEBUG: Magento\PageCache\Model\DepersonalizeChecker::checkIfDepersonalize {"request":"checkout:success","depersonalize ":false,"has quote in session":false}
I have this strange issue that when I enabled Full Page Cache (FPC), my checkout session's quote_id is removed whenever the visitor comes on an uncached page.
I suspect that this issue has something to do with the
\Magento\Checkout\Model\Layout\DepersonalizePlugin
, which runs aclearStorage()
on the session object so that no session-related information will be rendered accidentally in the templates.However, as soon as the session is closed, the "cleared" session data is written to the session. So the next time the page loads, there is no quote ID and a new quote is generated for the customer.
I'm not sure what goes wrong or what might be causing this, but it's already bugging me for 2 days now. I understand the need of clearing the session data for template rendering, but I was always in the assumption that this was temporary and not actually changing the session itself.
Preconditions (*)
Steps to reproduce (*)
Magento_Persistent
module (bin/magento module:disable
)?foo=bar
for example, so a new page will be called (cache miss)Expected result (*)
Actual result (*)