Changing form validation options loses validation messages translations

[gianisimone]

Preconditions (*)

1. Magento 2.3.0

Steps to reproduce (*)

1. Install a new language package on your store (I am working with the Italian locale).
2. Use the new installed language on your store.
3. Override the Magento_Catalog/templates/product/view/form.phtml template in your custom theme
4. Add custom validation settings for the form within this file. I did it in this way:

   <script type="text/javascript">
   var dataForm = $('#product_addtocart_form');
   dataForm.mage('validation', {
       errorPlacement: function(error, element) {
           if (element.siblings('.attribute-link-wrapper').length > 0) {
               error.insertAfter(element.siblings('.attribute-link-wrapper'));
           }
           else {
               error.insertAfter(element);
           }
       }
   });
   </script>

5. Try to submit the form without filling all the required information. You can try in the configurable product page.

Expected result (*)

1. The error messages relative to the missing field are shown in the current locale.

Actual result (*)

1. The error messages relative to the missing field are shown in the default locale (English). Also, all the other forms, show error messages in the default locale instead of the current one.

[magento-engcom-team]

Hi @gianisimone. Thank you for your report. To help us process this issue please make sure that you provided the following information:

• [ ] Summary of the issue
• [ ] Information on your environment
• [ ] Steps to reproduce
• [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gianisimone do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [ ] yes
• [ ] no

[hostep]

@gianisimone: this sounds like a duplicate of https://github.com/magento/magento2/issues/21204, do you agree?

When testing the other ticket myself, it looked like it is broken in 2.3.0 but is fixed on the 2.3-develop branch, so I'm hoping that the fix will be included in 2.3.1 (should get released next week somewhere)

[gianisimone]

@hostep I think it is a little bit different. In my case error messages translations work if I comment out the piece of code where I customize the errorPlacement callback. Without that part of code translations work fine for me.

[m2-assistant[bot]]

Hi @engcom-backlog-nazar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• [ ] 6. Add label Issue: Confirmed once verification is complete.

• [ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

[ghost]

hI @gianisimone thank you for you report, this issue has already fixed in 2.3.1 release. thanks for collaboration :+1: