magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.51k stars 9.31k forks source link

Catalog pricerules are not working with custom options as expected in Magento 2.3.0 product details page #22856

Open dcwnaveen opened 5 years ago

dcwnaveen commented 5 years ago

Catalog price rules are not working with custom options as expected in Magento 2.3.0 product details page. We created the catalog price-rule 10% discount for some x products and expecting the results like a 10% discount on total price( (product price + options price) * 10%). But results are showing discounted price + custom options price.

Preconditions Magento 2.4-develop PHP 7.3

Steps to reproduce

  1. Go to Admin->Marketing->Catalog Price Rule->Add New Rule;
  2. Fill all required fields and set Discount Amount to 10 % for ex.; Screenshot from 2020-06-10 12-30-57;
  3. Click on Save and Apply button;
  4. Create simple product (Price = 1000 $) with a drop-down custom option (Size for example); Options for Size:

Screenshot from 2020-06-10 12-34-54

  1. Go to Storefront;
  2. Open created before product;

Expected Result

We are expecting the 10% discount on the total price (product price + options price) * 10%). For:

Actual result

Its showings final prices like:

m2-assistant[bot] commented 5 years ago

Hi @dcwnaveen. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@dcwnaveen do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


m2-assistant[bot] commented 5 years ago

Hi @AlexWorking. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

dcwnaveen commented 5 years ago

@magento-engcom-team give me 2.3-develop instance So I will create the product and catalog price rule.

magento-engcom-team commented 5 years ago

Hi @dcwnaveen. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @dcwnaveen, here is your Magento instance. Admin access: https://i-22856-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

dcwnaveen commented 5 years ago

@magento-engcom-team I have created one product with custom options and created the catalog price rule. please reindex and run the cron job for a discounted price. https://i-22856-2-3-develop.instances.magento-community.engineering/product-a.html

dcwnaveen commented 5 years ago

Hi @AlexWorking. Please check the issue and confirm. https://i-22856-2-3-develop.instances.magento-community.engineering/product-a.html

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @AlexWorking Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99657, MAGETWO-99658 were created

Issue Available: @AlexWorking, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 5 years ago

Hi @p-bystritsky. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


VladimirZaets commented 4 years ago

Hi @dcwnaveen. Thank you for your report. The issue has been fixed in magento/magento2#22917 by @p-bystritsky in 2.4-develop branch Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

engcom-Alfa commented 4 years ago

After multiple discussion and several attempts to fix consequences was decided to revert this PR #22917

Purpose for revert During internal regression testing for future 2.4.0 release Core team found two regression bugs

  1. [MC-34245] Adding a Product with Customizable Option to Wish List results in a fatal error
  2. [MC-34322] Adding a Product with Customizable Option to a "Gift Registry" results in a fatal error when loading shared Gift Registry page

Root cause analysis defined that changes from #22917 brought these regression bugs.

So, we will reopen and confirm this issue again.

m2-assistant[bot] commented 4 years ago

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Alfa Thank you for verifying the issue. Based on the provided information internal tickets MC-35065 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

AbdulRahmanAbouzaid commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @AbdulRahmanAbouzaid. Thank you for your request. I'm working on Magento 2.4-develop instance for you

AbdulRahmanAbouzaid commented 4 years ago

@magento-engcom-team give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @AbdulRahmanAbouzaid. Thank you for your request. I'm working on Magento 2.4-develop instance for you

sdzhepa commented 3 years ago

The issue has been fixed by Magento team and delivered with internal PR Related commits https://github.com/magento/magento2/search?q=MC-35065&type=commits

ashar01 commented 1 year ago

@sdzhepa @magento-engcom-team @VladimirZaets This ticket says the issue is fixed but i am bit confused after reading this https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/support-tools/patches/v1-1-23/acsd-47107-catalog-price-rule-is-applied-to-custom-options.html?lang=en This document says magento reverts this fix in m2.4.6 release.

sprankhub commented 9 months ago

@sdzhepa @magento-engcom-team, could you please check the last comment?

engcom-Dash commented 8 months ago

Hi @dcwnaveen

Thank you for reporting and collaboration.

Verified the issue in Magento 2.4.7-beta2 and 2.4 dev instances and the issue is reproducible in both the instances.

Catalog price rules are not working with custom options.

Please refer the attached screenshots.

Screenshot 2024-01-22 at 3 15 17 PM Screenshot 2024-01-22 at 3 15 17 PM Screenshot 2024-01-22 at 4 22 02 PM
github-jira-sync-bot commented 8 months ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 8 months ago

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

github-jira-sync-bot commented 8 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-10902 is successfully created for this GitHub issue.

m2-assistant[bot] commented 8 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.