search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Configurable - no weight for child products - makes configurable virtual type - no shipping details on checkout #23181

Open tomekjordan opened 5 years ago

tomekjordan commented 5 years ago

Configurables child by default doesnt have weight set in Edit Configurable (creators), when Main Configurable product is not saved with Weight before. So when you forget it - and save later Configurable and its childs > there are no Shipment step at checkout. Checkot proceed like for virtual products - cannot ship to destination

Preconditions (*)

  1. Any Magento 2 (tested on M 2.3.1)
  2. default config php 7,mysql, apache
  3. Varnish disabled for pure results

Steps to reproduce (*)

  1. Create Configurable product - dont add any weight on it. Dont Save.
  2. Move to -> Create child products> with edit configuration. FORGET to add any weight to childs in table after edit configuration is finished.
  3. Save created configurable.
  4. Add to Cart configurable product
  5. Checkout doesnt show Shipment details (destination address - becuase configurable is treated like "virtual" kind
  6. Later Weight attribute can be filled after edit Configuration again - BUT is not giving result. Value is saved, but not reflecting on frontend > checkout still doesnt have Shipment step (indexing, flush cache doesnt fix it)

Expected result (*)

  1. Edit Configuration should just include weight field to edit OR
  2. When configurable's childs are created please allow fields like price, weight to be edited right on configurable product - just like it is done before Configurable save after childs are created - fields are open to input values. But when you Save Configurable finally - fields are marked read only.

Screenshot_9

Actual result (*)

  1. When you forget to set weight and save configurable's child without weight >
  2. You can checkout configurable BUT it doesnt provide Shipment step - so checkout process is just like for virtual products - you cannot ship it because you dont have details about weight.
m2-assistant[bot] commented 5 years ago

Hi @tomekjordan. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@tomekjordan do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

m2-assistant[bot] commented 5 years ago

Hi @EternalBobby. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @EternalBobby Thank you for verifying the issue. Based on the provided information internal tickets MC-17465, MC-17466 were created

Issue Available: @EternalBobby, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

seansan commented 5 years ago

This issue is also reported here https://magento.stackexchange.com/questions/103864/while-creating-configure-product-its-associate-product-are-virtual-instead-of-s

More important: We dont think virtual product creation yes/no should rely solely on a missing weight

We import many many products via sheets/api and sometimes the weight is at this time not known ==> would the result then really really be that we have created dummy/unwanted simple virtual products

Swahjak commented 5 years ago

We dont think virtual product creation yes/no should rely solely on a missing weight

I would like to second that. It's quite common that weights are not immediately available when adding a product. In general it seems more logical (and common) that the default should be simple not virtual.

viniciusbordinhao-blueacorn commented 3 years ago

@magento I am working on it

seansan commented 3 years ago

I agree with you

On Thu, 18 Jul 2019 at 12:08, Peep van Puijenbroek notifications@github.com wrote:

We dont think virtual product creation yes/no should rely solely on a missing weight I would like to second that. It's quite common that weights are not immediately available when adding a product. In general it seems more logical (and common) that the default should be simple not virtual.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/23181?email_source=notifications&email_token=AAE7I24Z4VGDY5UZ63I72X3QAA6LNA5CNFSM4HWJJN3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2H7ZQI#issuecomment-512752833, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE7I22QJCJ7NZNS772I4E3QAA6LNANCNFSM4HWJJN3A .

quterorta commented 1 year ago

I could reproduced it on 2.4.5

m2-assistant[bot] commented 2 months ago

Hi @engcom-Delta. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

engcom-Delta commented 2 months ago

Hi @tomekjordan ,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and it is an improvement so we will mark ticket as feature request.

Steps to reproduce :

  1. Create a Configurable Products with no weight image

  2. Access Frontend and add item to cart and navigate to checkout image

  3. Now Add weight to the child product and save. image

  4. Reindex and clear cache.

  5. Navigate to checkout and observe shipping address and shipping method is displaying as expected image

Improvement - Edit Configuration should just include weight field to edit OR When configurable's childs are created please allow fields like price, weight to be edited right on configurable product - just like it is done before Configurable save after childs are created - fields are open to input values. But when you Save Configurable finally - fields are marked read only. image

Thanks.