Usage of non-numeric value for "Number of Products to Display" setting in "Catalog Products List" widget leads to an exception

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.53k stars 9.31k forks source link

Usage of non-numeric value for "Number of Products to Display" setting in "Catalog Products List" widget leads to an exception #23422

Open Deathrezen opened 5 years ago

Deathrezen commented 5 years ago

Preconditions

Magento 2.3.1 EE with sample data installed
PHP 7.2

Steps to reproduce

Open any CMS page
In "Content" field add a Catalog Products List widget with settings: Title = title Number of Products to Display = azaza (or any other non-numeric value) Display Page Control = No Other settings have default values
Save the widget
Save the CMS page
Go to the CMS page

Expected result

Step 3: Validation error appears as widget is saved due to incorrect input

Actual result

Step 5: Exception: A non-numeric value encountered http://dl4.joxi.net/drive/2019/06/26/0023/4040/1548232/32/4a91df8f78.jpg

Additional Information

no exception now but validation should be https://github.com/magento/magento2/issues/23422#issuecomment-625853614

m2-assistant[bot] commented 5 years ago

Hi @Deathrezen. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Deathrezen do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

sdzhepa commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @sdzhepa, here is your Magento instance. Admin access: https://i-23422-2-4-develop.instances.magento-community.engineering/admin_f68f Login: 321b6914 Password: 2c361118c83c Instance will be terminated in up to 3 hours.

sdzhepa commented 4 years ago

Hello @Deathrezen

We verified this issue on the lates 2.4-develop branch code. There are no exceptions now in logs and the page opened successfully. But I gree validation make sense anyway!

We checked by adding the "Catalog Products List" widget on the Home page. Current behavior:

Number of Products to Display = 5a -> Result: 5 products are shown on Home Page
Number of Products to Display = zas4 -> Result: 1 product
Number of Products to Display = azazaz -> Result: 1 product

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @sdzhepa Thank you for verifying the issue. Based on the provided information internal tickets MC-34168 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 6 months ago

Hi @engcom-Bravo. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
1. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

engcom-Bravo commented 6 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 6 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://8c3b6e50c006a0612048446a7b62e565.instances-prod.magento-community.engineering Admin access: https://8c3b6e50c006a0612048446a7b62e565.instances-prod.magento-community.engineering/admin_eb47 Login: eb8d02d2 Password: 943f22cc960c

engcom-Bravo commented 6 months ago

Hi @Deathrezen,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

Open any CMS page
In "Content" field add a Catalog Products List widget with settings:
Title = title
Number of Products to Display = azaza (or any other non-numeric value)
Display Page Control = No
Other settings have default values
Save the widget
Save the CMS page
Go to the CMS page

Even though we have given non numeric value the products are still showing in the CMS page and there should be validation before saving with non numeric value.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 6 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11849 is successfully created for this GitHub issue.

m2-assistant[bot] commented 6 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

github-jira-sync-bot commented 6 months ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11849

github-jira-sync-bot commented 6 months ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11849

github-jira-sync-bot commented 6 months ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11849