magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

UPS shipping booking and label generation gives error when shipper's street given more than 35 chars #23522

Closed ankurvr closed 5 years ago

ankurvr commented 5 years ago

Preconditions (*)

  1. Magento v2.2.5
  2. Ubuntu 16.04
  3. UPS Shipping method enabled with shipping label generation enabled

Steps to reproduce (*)

  1. Configure Origin in In shipping settings and address should be (Street1 : "Xth Floor, The Great Persis,", Street2: "D95 Road No 91, LIPC, Anpheri (G)"), the logic is to make total characters by combining both street should be more than 35 chars.
  2. Place and order with any Germany city address by selecting any of the available UPS shipping method.
  3. Now create shipment for an order. While creating shipment check the checkbox "create shipping label" and proceed.
  4. After filling details in create packages form do click save

Expected result (*)

  1. On successful completion of above steps it should book shipment on UPS and give shipping label in response.

Actual result (*)

  1. Instead of booking shipment on UPS it gives error saying "Missing or invalid ship from address line 1"

    Screen Shot 2019-07-01 at 4 28 08 PM
  2. Here the issue behind error is the length of ship from address street length, which is more than 35, which is set by UPS stated in documentation

    Screen Shot 2019-07-01 at 4 15 04 PM
  3. The actual length of stree1 data in shipment origin setting is less than 35 but it's sending stree1 and stree2 concatenated.

Request XML (* For security reasons phone numbers are masked with 0)

`<?xml version="1.0"?>

**** **** ****
    <?xml version="1.0"?>
ShipConfirm nonvalidate bracelet7fthollow 003 wonder_woman_ Alphabets Ankur R XXXXXX +912267000000
Xth Floor, The Great Persis, D95 Road No 91, LIPC, Anpheri (G) Road No 91, LIPC, Anpheri (G) Mumbai IN 400090 MH
Ankur R Hotel Berlin Berlin +490000000
Lützowpl. 17 Berlin DE 10785 BER
54 bracelet7fthollow 003 wonder_woman_ 00 297 LBS IN 15 15 15 1 7R7147
GIF GIF
` #### Response XML ` 0 Failure Hard 120302 Missing or invalid ship from address line 1 `
m2-assistant[bot] commented 5 years ago

Hi @ankurvr. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ankurvr do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


ankurvr commented 5 years ago

@magento give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @ankurvr. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @ankurvr, here is your Magento instance. Admin access: https://i-23522-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

magento-engcom-team commented 5 years ago

Hi @ankurvr. Thank you for your report. The issue has been fixed in magento/magento2#23523 by @ankurvr in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

magento-engcom-team commented 5 years ago

Hi @ankurvr. Thank you for your report. The issue has been fixed in magento/magento2#23603 by @ankurvr in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

juejijianghuaa commented 1 year ago

"AddressLine": ["werqweeeeeeeeeeeeeeeeeeeeeeeeeeeeer","12312312333333333333"] is ok