magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

[Authorize.net accept.js] "Place Order" button not being disabled #23624

Closed simonlandry0 closed 5 years ago

simonlandry0 commented 5 years ago

Preconditions (*)

  1. Magento 2.3.2
  2. Configure and setup authorize.net accept js payment method

Steps to reproduce (*)

  1. Place non-free item in cart
  2. Proceed to checkout.
  3. Enter shipping information and proceed to the billing step.
  4. Use Authorize.net accept js payment method.
  5. Fill out billing information + card details but don't hit the "update" button (this would make isPlaceOrderActionAllowed() return false)

Expected result (*)

  1. The place order button at the bottom should be disabled as long as billing information is not updated (Similiar to how the old authorize.net extension, the brain tree extension and the paypal extension work).

Actual result (*)

  1. Place order button is always enabled regardless of isPlaceOrderActionAllowed()'s return (unlike how the old authorize.net extension, the brain tree extension and the paypal extension currently work)
  2. Will return reported confusing errors for customers when the form is submitted without first updating billing information. Bad UX.
m2-assistant[bot] commented 5 years ago

Hi @simonlandry0. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@simonlandry0 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


m2-assistant[bot] commented 5 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 5 years ago

@magento give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @engcom-Bravo, here is your Magento instance. Admin access: https://i-23624-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

engcom-Bravo commented 5 years ago

magento give me 2.2-develop instance

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-17996 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 5 years ago

Hi @edenduong. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


magento-engcom-team commented 5 years ago

Hi @simonlandry0, @edenduong.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.3 release.