search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Mage_Shipping_Model_Resource_Carrier_Tablerate::uploadAndImport reads from $_FILES #242

Closed amenk closed 11 years ago

amenk commented 11 years ago

I think this method should not read from $_FILES. This is not a clear separation in the code. Instead it should be passed the filename directly.

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php#L187

magento-team commented 11 years ago

Hello. Would you be able to contribute this is a pull request? There are also existing uploader classes that you might be able to reuse

amenk commented 11 years ago

If I find some time, yes... Which are the uploader classes are you talking about?

nevvermind commented 11 years ago

@amenk - I think they're referring to Varien_File_Uploader.

magento-team commented 11 years ago

Closing due to lack of activity. Please comment if you think you might be able to contribute a pull request.