Shipping address and shipping method lost when refresh payment step

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.49k stars 9.31k forks source link

Shipping address and shipping method lost when refresh payment step #24585

Closed sunilit42 closed 3 years ago

sunilit42 commented 5 years ago

Preconditions (*)

Latest Magento 2.3
Customer has login
Customer contain at least two address

Steps to reproduce (*)

login as customer
add two address
add product into cart
configure one payment with wrong details e.g authorize.net Deprecated or braintree and use card details 5 select other than default address
go to next step (payment page)
select that payment method and do place order
after get error msg from payment & reload that page
in sidebar you can see default shipping address not that address that you selected on first step

Expected result (*)

it should keep current address into sidebar

Actual result (*)

default shipping address are set on sidebar

m2-assistant[bot] commented 5 years ago

Hi @sunilit42. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@sunilit42 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[x] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 5 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 5 years ago

Hi, @sunilit42, thanks for applying. Please specify what do You mean under: "in sidebar you can see default shipping address..."? You are supposed to stay on the Payment page "after get error msg from payment & reload that page". And if You are still on the Payment Page there is no shipping address on it but only the billing address - the address You haven't changed and therefore it remains the default one. As I understand You have changed only the shipping address when "select other than default address", because after that You say "go to next step (payment page)". So when You changed the the address from the default to non-default one You were on the Shipping page and that could be only the shipping address. The payment address still remained the default one.

sunilit42 commented 5 years ago

Hello @engcom-Bravo Thanks for checking 1) go to the checkout 2) select other than the default shipping address 3) select any shipping method 4) click on next 5) select any payment method 6) https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Checkout/Model/PaymentInformationManagement.php#L84 add throw new CouldNotSaveException( __('A server error stopped your order from being placed. Please try to place your order again.'), $e );

so it will not placed order 7) check the sidebar of checkout summary ( shipping address + shipping method) 8) now refresh the page and check the sidebar of checkout summary ( shipping address + shipping method) 9) now compare 7 and 8 shipping address and shipping method

engcom-Bravo commented 5 years ago

Ok @sunilit42, I was cared only about the address displayed in the main page's content. This "...check the sidebar of checkout summary..." made everything clear. Thank You, I'm confirming the issue)

magento-engcom-team commented 5 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-20171 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 5 years ago

Hi @mahsn. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

[ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

vivekkumar945744 commented 5 years ago

@magento give me 2.3-develop instance

magento-engcom-team commented 5 years ago

Hi @vivekkumar-webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team commented 5 years ago

Hi @vivekkumar-webkul, here is your Magento instance. Admin access: https://i-24585-2-3-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

sdzhepa commented 3 years ago

We are not able to reproduce this issue on the latest 2.4-develop code using the provided steps to reproduce from description It seems it was already fixed in the scope of another task/pr/issue/etc.

But if this issue can be reproduced on the latest code with some different steps please create new issue