magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

Wrong program code in "Magento/Checkout/view/frontend/web/js/view/summary/shipping.js" #25529

Closed andrewbess closed 4 years ago

andrewbess commented 4 years ago

Preconditions (*)

  1. Seems there is wrong code in Magento_Checkout/js/view/summary/shipping

return shippingMethod ? shippingMethod['carrier_title'] + shippingMethodTitle : shippingMethod['carrier_title'];

What can happen if shippingMethod will not be an array?

Steps to reproduce (*)

  1. Set shipping method as type "string" in the quote like a quote.shippingMethod('test')
  2. Check the sidebar on step 2

Expected result (*)

  1. Shipping shouldn't look javascript type "undefined"

Actual result (*)

  1. Incorrect delivery display
m2-assistant[bot] commented 4 years ago

Hi @andrewbess. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@andrewbess do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


m2-assistant[bot] commented 4 years ago

Hi @andrewbess. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:


magento-engcom-team commented 4 years ago

Hi @andrewbess. Thank you for your report. The issue has been fixed in magento/magento2#25530 by @andrewbess in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.5 release.