magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.54k stars 9.31k forks source link

mutation createEmptyCart doesn't throw exception when authorization header is set and token has expired #26112

Closed TomashKhamlai closed 2 years ago

TomashKhamlai commented 5 years ago

Preconditions (*)

  1. Registered Customer is created

Steps to reproduce (*)

  1. Generate Customer token
  2. Wait for token expiration
  3. Create empty cart using expired token

Expected result (*)

  1. Cart is not created because token has expired
    "message": "The current customer isn't authorized.",
    "category": "graphql-authorization"
  2. Guest cart is not created because token was used

Actual result (*)

  1. Guest cart is created
rafaelstz commented 5 years ago

As we talked @naydav: Please, take into account also confirmation status of the customer.

m2-assistant[bot] commented 4 years ago

Hi @TomashKhamlai. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@TomashKhamlai do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


m2-assistant[bot] commented 4 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-29927 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 4 years ago

Hi @engcom-Charlie. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-29927).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-29927).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-29927).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-29927).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-29927).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-29927).

m2-assistant[bot] commented 4 years ago

Hi @pmarjan. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


m2-assistant[bot] commented 4 years ago

Hi @TomashKhamlai. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


mauragcyrus commented 3 years ago

Hi @TomashKhamlai we have a proposal from architects here: https://github.com/magento/architecture/blob/deprecate-createEmptyCart-add-createCart/design-documents/graph-ql/coverage/deprecate-createEmptyCart-add-createGuestCart.md on how to handle this fix if you would like to take a look :)

mauragcyrus commented 3 years ago

Two very similar issues: https://github.com/magento/magento2/issues/29922

engcom-Hotel commented 2 years ago

Hello @TomashKhamlai,

We have tried to reproduce the issue in Magento 2.4-develop branch and we have the below findings. we have tried with an expired token and we are not able to get the cart created.

followed steps:-

Please find the below screen for your reference.

image

As the issue is not reproducible, hence we are closing the issue. Let us know in case you are still able to reproduce the issue.

Thanks