Shipping Title translation is not being translated when you switch the langauge in Checkout Cart Page

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.56k stars 9.32k forks source link

Shipping Title translation is not being translated when you switch the langauge in Checkout Cart Page #26388

Closed zexperto closed 4 years ago

zexperto commented 4 years ago

Preconditions (*)

Magneot 2.3.3

Steps to reproduce (*)

Add Two Store views
Change the Label for Free Shipping method in the second store
add a new product to be able to order it
disable multi shipping address
add the product to cart
go to the Checkout cart page
switch the languages
look at the shipping label in the right sidebar

Expected result (*)

when we switch the language we have to see the correct label per store view

Actual result (*)

we see don't see the correct language and we see the other language , when we change any information in the estimation shipping cost we got the correct label

m2-assistant[bot] commented 4 years ago

Hi @zexperto. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@zexperto do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

zexperto commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @zexperto. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @zexperto, here is your Magento instance. Admin access: https://i-26388-2-4-develop.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

zexperto commented 4 years ago

Cannot reproduce it on Magento 2.4

m2-assistant[bot] commented 4 years ago

Hi @shikhamis11. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

shikhamis11 commented 4 years ago

@magento give me 2.3.3 instance

magento-engcom-team commented 4 years ago

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3.3 instance for you

shikhamis11 commented 4 years ago

@zexperto try reproducing this issue at 2.3.3 and share screenshots if you are able to reproduce this issue

magento-engcom-team commented 4 years ago

Hi @shikhamis11, here is your Magento instance. Admin access: https://i-26388-2-3-3.instances.magento-community.engineering/admin Login: admin Password: 123123q Instance will be terminated in up to 3 hours.

zexperto commented 4 years ago

I have updated the issue by adding "disable multi shipping" and i am able to reproduce it in both versions please see the screenshots

shikhamis11 commented 4 years ago

@zexperto thanks for the update. I will check the issue and update it's status

shikhamis11 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @shikhamis11, here is your Magento instance. Admin access: https://i-26388-2-4-develop.instances.magento-community.engineering/admin_6e1d Login: 1e816f5e Password: a1f34bc8624f Instance will be terminated in up to 3 hours.

shikhamis11 commented 4 years ago

@magento give me 2.3.3 instance

magento-engcom-team commented 4 years ago

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3.3 instance for you

magento-engcom-team commented 4 years ago

Hi @shikhamis11, here is your Magento instance. Admin access: https://i-26388-2-3-3.instances.magento-community.engineering/admin_9219 Login: 7d42de8d Password: 0d396d6000ab Instance will be terminated in up to 3 hours.

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @shikhamis11 Thank you for verifying the issue. Based on the provided information internal tickets MC-30470 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 4 years ago

Hi @madhu-ranosys. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

[ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 2. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 4 years ago

Hi @mallikaverma. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

[ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 2. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

mallikaverma commented 4 years ago

@magento give me 2.4-develop instance

gaurav-473 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @gauravagarwal1001, here is your Magento instance. Admin access: https://i-26388-2-4-develop.instances.magento-community.engineering/admin_f1f4 Login: 8f9883ac Password: f7aba51d9e8e Instance will be terminated in up to 3 hours.

sdzhepa commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @sdzhepa, here is your Magento instance. Admin access: https://i-26388-2-4-develop.instances.magento-community.engineering/admin_214a Login: 32045e15 Password: d81241453877 Instance will be terminated in up to 3 hours.

sdzhepa commented 4 years ago

Hello @zexperto

I am not able to reproduce this bug now on the lates 2.4-develop code Probably it was already fixed.

Steps

A simple product is created
Free shipping is enabled Configuration>SALES>Shipping Methods > Free Shipping
Two Stores are created with one website
Set Different Titles for Free Shipping on each store view
Flush all required caches
Go to Storefront and product and go to Shopping Cart
Check Title for Free shipping on Default store view
Check Title for Free shipping on Second Store View

2020-06-26_8-51-02

gauravharsh15 commented 7 months ago

@magento-engcom-team, please reopen this ticket, I am able to reproduce it on Magento-2.4.5-p1