Product video doesn't play when it is not placed first in the sort order.

aashan10 commented 4 years ago

Preconditions (*)

Magento Version : 2.2.9
- PHP 7.1.32
- MySQL Ver 14.14 Distrib 5.7.28, for Linux (x86_64) using EditLine wrapper
Sample data is used.

Steps to reproduce

Edit the simple product of a configurable product and add a product video. ( In our case, we have used Chaz Kangeroo Hoodie as Configurable Product and Chaz Kangeroo Hoodie-XS-Black as its simple product )
The video used is https://www.youtube.com/watch?v=L4XjEuCPOJY.
Now, sort the video in media gallery to make it seen anywhere but not the first position.
Save the product.
View the configurable product in storefront product details page.
Click on the color swatch to view the simple product media gallery.
Click the video thumbnail and play the video.

Imgur Imgur

Expected result

The video should play when clicked on the thumbnail.

Actual result

Only the thumbnail image of the youtube video is visible.
The video is not played if the video is not in the first position according to the sort order in admin panel.

Imgur

Addition Information

https://github.com/magento/magento2/issues/26709#issuecomment-602561906

I could easily reproduce the issue on the latest 2.4-develop youtube_video_26709

magento-deployment-service[bot] commented 4 years ago

Thanks for opening this issue!

m2-assistant[bot] commented 4 years ago

Hi @aashan10. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@aashan10 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 4 years ago

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[x] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[x] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[x] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

ajijshekh123 commented 4 years ago

Give me @magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @ajijshekh123, here is your Magento instance. Admin access: https://i-26709-2-4-develop.instances.magento-community.engineering/admin_723b Login: d5dd5377 Password: 0ad3122db139 Instance will be terminated in up to 3 hours.

ajijshekh123 commented 4 years ago

Hello @aashan10, After clicking on a video, Youtube video is played properly. See attached the video and Let me know which points are missing in my end or is it working fine.

Issue

Thanks.

matthew-muscat commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @matthew-muscat. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @matthew-muscat, here is your Magento instance. Admin access: https://i-26709-2-4-develop.instances.magento-community.engineering/admin_36ba Login: c6016c60 Password: 7ca19cfdb748 Instance will be terminated in up to 3 hours.

matthew-muscat commented 4 years ago

@ajijshekh123 — confirming i'm able to repeat the issue on Magento v2.3.4 and also the latest Magento 2.4-develop snapshot.

The behaviour specifically occurs when viewing a configurable product, making a selection of a specific configuration, which contains a video located in any area other than the first image position.

If the instance remains online, this can be viewed over at... https://i-26709-2-4-develop.instances.magento-community.engineering/example-configurable-product.html

ezgif com-video-to-gif

matthew-muscat commented 4 years ago

Upon further investigation, it appears that this issue is due to the data on the Magento_ProductVideo/js/fotorama-add-video-events widget

Specifically optionsVideoData looks to have the video data always set as the first object in the array of product media gallery assets.

It would appear the sort order of the gallery is not occurring in https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/Block/Plugin/Product/Media/Gallery.php#L62

ghost commented 4 years ago

:white_check_mark: Confirmed by @matthew-muscat Thank you for verifying the issue! :+1: Your confirmation will help us to acknowledge and process this report.

m2-assistant[bot] commented 4 years ago

Hi @vishvesshah. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

vishvesshah commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @vishvesshah. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @vishvesshah, here is your Magento instance. Admin access: https://i-26709-2-4-develop.instances.magento-community.engineering/admin_5ee0 Login: 784cad54 Password: c164cf35ac63 Instance will be terminated in up to 3 hours.

m2-assistant[bot] commented 4 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 4 years ago

I could easily reproduce the issue on the latest 2.4-develop youtube_video_26709

Seems like there is no Play on the video

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-32647 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] commented 4 years ago

Hi @LucasCalazans. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

[ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 2. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

LucasCalazans commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @LucasCalazans. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @LucasCalazans, here is your Magento instance. Admin access: https://i-26709-2-4-develop.instances.magento-community.engineering/admin_4c65 Login: 597c5e5c Password: 8e599f4e1745 Instance will be terminated in up to 3 hours.

tuyennn commented 2 years ago

https://github.com/magento/magento2/issues/29690 https://github.com/magento/magento2/issues/28875 https://github.com/magento/magento2/pull/30938

m2-assistant[bot] commented 5 months ago

Hi @engcom-Delta. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
1. Verify that the issue is reproducible on 2.4-develop branch
  Details
  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
1. If the issue is not relevant or is not reproducible any more, feel free to close it.