Checkout loader mask remains indefinitely if terms and conditions box is unchecked

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.49k stars 9.31k forks source link

Checkout loader mask remains indefinitely if terms and conditions box is unchecked #26797

Closed g-anedda closed 4 years ago

g-anedda commented 4 years ago

Preconditions (*)

Magento 2.3.3-p1
Use Braintree payment method
Have terms and conditions on payment page, with manual option to check

Steps to reproduce (*)

Have 3D Secure enabled on Braintree payment method
Fill all data for shipping and billing, leaving the Terms and Conditions checkbox unchecked
Try to place the order

Expected result (*)

The loader mask should appear after the click to place the order
The validation should fail because of the unchecked t&c box
The loader mask should disappear
The message "This is a required field." in red should appear near the t&c checkbox

Actual result (*)

The loader mask remains in place
Underneath the mask the red label "This is a required field." is visible, but no operation is allowed because the loader mask is still in place

screen

m2-assistant[bot] commented 4 years ago

Hi @ganedda-softfobia. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ganedda-softfobia do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

g-anedda commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ganedda-softfobia. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @ganedda-softfobia, here is your Magento instance. Admin access: https://i-26797-2-4-develop.instances.magento-community.engineering/admin_a70b Login: 75d1ea64 Password: b62541446c9c Instance will be terminated in up to 3 hours.

g-anedda commented 4 years ago

I am able to reproduce issue on magento vanilla instance.

m2-assistant[bot] commented 4 years ago

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

ajijshekh123 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @ajijshekh123, here is your Magento instance. Admin access: https://i-26797-2-4-develop.instances.magento-community.engineering/admin_1cee Login: 162350fa Password: 6d3edb22a9af Instance will be terminated in up to 3 hours.

ajijshekh123 commented 4 years ago

Hi @ganedda-softfobia, I have reproduced this issue in default Magento 2.4 Instance as per defined steps. See attached the video: Payment_T C_Issue

Thanks.

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @ajijshekh123 Thank you for verifying the issue. Based on the provided information internal tickets MC-31471 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-31471).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-31471).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-31471).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-31471).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-31471).

magento-engcom-team commented 4 years ago

:x: Something went wrong. Cannot update Jira issue (https://jira.corp.magento.com/browse/MC-31471).

sdzhepa commented 4 years ago

Hello @g-anedda

Thank you for your report and collaboration!

Unfortunately, we are closing this Issue report because we are not able to process contribution to the 2.3.x release line through this public repository. See details Code Contributions: Accepted pull requests and ported code And starting from 2.4.0 release, code related to this payment was removed for Magento code-base: Magento Commerce 2.4.0 Release Notes

With this release, the Authorize.Net, Braintree, eWay, CyberSource, and Worldpay payment method integrations have been removed from core code. Merchants should migrate to the official extensions that are available on the Magento Marketplace.

Deprecation of Magento core payment integrations

All questions, reports should be addressed to the corresponding extension owners(support) on the Magento Market place page