search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Magento 2 core JS not following new pattern for loading jQuery UI modules #27120

Closed jlczapski closed 4 years ago

jlczapski commented 4 years ago

Preconditions (*)

  1. Magento v2.3.4
  2. On any page where 'jquery/ui' has been loaded via JS

Steps to reproduce (*)

  1. When page loads, a warning is thrown in console saying Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site.

Expected result (*)

  1. Screenshot 2020-03-02 at 10 42 58 (2)
  2. Only required jQuery UI modules should be loaded. Since jQuery UI modules are now split into separate files, using 'jquery/ui' will load all modules unnecessarily, leading to poorer page load times.

Actual result (*)

  1. Screenshot 2020-03-02 at 10 38 22 (2)
  2. For example, when creating a widget, the require statement should be using the new pattern of 'jquery-ui-modules/widget' instead of 'jquery/ui'
m2-assistant[bot] commented 4 years ago

Hi @jlczapski. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@jlczapski do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

jlczapski commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @jlczapski. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @jlczapski, here is your Magento instance. Admin access: https://i-27120-2-4-develop.instances.magento-community.engineering/admin_576e Login: 333a3983 Password: d7ed83ca6e59 Instance will be terminated in up to 3 hours.

jlczapski commented 4 years ago

Could not reproduce on 2.4-develop and looks like it has been fixed in JS files, so guessing this will be part of the release?

magento-engcom-team commented 4 years ago

Hi @sunilit42. Thank you for your request. Unfortunately, I can only deploy instances for 2.3 and 2.4 release line

engcom-Bravo commented 4 years ago

Hello @jlczapski

Thank you for your report

Yes, this fix will be a part of the upcoming 2.3.5 release

If you'll ever face any issues with Magento, please, feel free create new ticket according to the Issue reporting guidelines

Thank you for collaboration

onepack commented 4 years ago

@engcom-Bravo What changes are included for this fix for the 2.3.5 release? Any references?