Subtitle got hidden in backend menu

[BrokenMop]

Preconditions:

1. Magento 2.4-develop
2. Magento version 2.3.4

Steps to reproduce:

1. Add at least two menu items under backend Content menu ( Test Menu 2, Test Menu 3 for example);

e.g. So now, we have totally 4 submenus under the Content menu: Elements, Design, Test Menu 2, and Test Menu 3

2. Use ACL to hide Design to current backend users. ( Go to Admin -> System -> User Roles and open current role for edit);

Expected result: :heavy_check_mark:

1. All menu shows correctly, Design will get hidden for the user.

Actual result: :heavy_multiplication_x:

1. All menu shows correctly, Design will get hidden for the user.
2. The Subtitles for Elements, Test Menu 2, Test Menu 3 are hidden by the CSS below

.adminmenu .submenu .column:only-of-type .submenu-group-title, .adminmenu .level-0 > .submenu > ul > .level-1:only-of-type > .submenu-group-title { display: none; }

The first selector actually hides the subtitle.

Observation: Looks like Magento groups submenu into columns when there are multiple, but when there is only 1 column, the subtitle is hidden by the CSS.

[m2-assistant[bot]]

Hi @BrokenMop. Thank you for your report. To help us process this issue please make sure that you provided the following information:

• [ ] Summary of the issue
• [ ] Information on your environment
• [ ] Steps to reproduce
• [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@BrokenMop do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [ ] yes
• [ ] no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[BrokenMop]

Yes I can confirm the issue on vanilla Magento instance

[m2-assistant[bot]]

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

:white_check_mark: Confirmed by @engcom-Alfa Thank you for verifying the issue. Based on the provided information internal tickets MC-40292 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[gixid192]

I think this is intended, just don't know the right cases for this css. Otherwise, we can safely remove it.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[lfolco]

It's still relevant, you need the headings there.

[lfolco]

This also occurs if you add an additional menu, making the total count three. For example, I have an additional menu under Content where the subtitles do not show:

But, when I add a fourth grouping, it shows up:

This is a full admin user; I did not change any ACL.

[mskalny]

Add it to for example Vendor/Module/view/adminhtml/web/css/source/_module.less as a temporary solution:

body {
  .admin__menu {
    .submenu {
      .column:only-of-type {
        .submenu-group-title {
          display: block;
        }
      }
    }

    .level-0 {
      & > .submenu {
        & > ul {
          & > .level-1:only-of-type {
            & > .submenu-group-title {
              display: block;
            }
          }
        }
      }
    }
  }
}

[markshust]

I've confirmed the same issue as @lfolco, this is definitely a bug.

Out of the box, Magento's HTML structure looks like this:

Notice how there is a single <ul role="menu"> element.

Now, when I add a new third item with a child, the headers are hidden due to the CSS in this screenshot. This seems to be triggered because a child <ul role="menu"> element is contained within a parent <ul role="menu"> element, as well as a .column el which wasn't previously present:

If I create a second custom menu item (with no child, as just a placeholder), the headers show back up, but a second column shows (which is obviously unintended):

The headers show back up because there are two .column elements, so the .column:only-of-type CSS rule is not activated.

[m2-assistant[bot]]

Hi @engcom-Delta. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 2. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.