magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.59k stars 9.32k forks source link

In the invoice it is not shown, if the invoice email has been sent or not #27474

Closed norgeindian closed 1 year ago

norgeindian commented 4 years ago

Preconditions (*)

Magento 2.3.4

Steps to reproduce (*)

  1. Create an order
  2. Create the corresponding invoice in the backend
  3. Open the invoice in the backend and take a look at the header

Expected result (*)

I would assume to see an information in the header section of the invoice, which informs me if the invoice email has been sent or not. It was this way in Magento 1, it is available for the order, but not for the invoice. So you only see, if the order confirmation mail has been sent out, but not if the invoice is actually sent or not.

Actual result (*)

No email hint is shown. Screenshot from 2021-05-05 10-50-54

I debugged this issue a bit. The email hint would normally be processed by \Magento\Sales\Block\Adminhtml\Order\Invoice\View::getHeaderText. But this function is never called as far as I can see. The corresponding block is defined in vendor/magento/module-sales/view/adminhtml/layout/sales*order_invoice*view.xml:14, but has no template defined. In the end this block is initialized in \Magento\Sales\Controller\Adminhtml\Order\Invoice\View::execute where the title is set. But there only the invoice increment id is shown, no status hint.

m2-assistant[bot] commented 4 years ago

Hi @norgeindian. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@norgeindian do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


m2-assistant[bot] commented 4 years ago

Hi @shikhamis11. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

shikhamis11 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @shikhamis11, here is your Magento instance. Admin access: https://i-27474-2-4-develop.instances.magento-community.engineering/admin_5e79 Login: 0ba49f1c Password: f1a98bbb5c9f Instance will be terminated in up to 3 hours.

shikhamis11 commented 4 years ago

Hi @norgeindian I checked and found the email sent information is there in invoice view on magento 2.4 instance Please check below image

image

sprankhub commented 4 years ago

@shikhamis11 please mind that @norgeindian is talking about the invoice email. In your screenshot, I can see that there is a note that the order confirmation email was not sent, but nothing is shown regarding the invoice email. Could you please double check?

m2-assistant[bot] commented 4 years ago

Hi @sudheers-kensium. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @sudheers-kensium Thank you for verifying the issue. Based on the provided information internal tickets MC-32976 were created

Issue Available: @sudheers-kensium, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

luanalves commented 4 years ago

Hi @norgeindian default magento send email from invoice, and send custom information when write comment in box

m2-assistant[bot] commented 4 years ago

Hi @luanalves. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


luanalves commented 4 years ago

@shikhamis11 why do you remove the assignment ? I'm response your question

norgeindian commented 4 years ago

@luanalves , @shikhamis11 , during the invoice creation step a backend user can choose if the invoice mail should be sent or not. As it is possible to send the mail later again in the backend view of the invoice, it should be visible if the mail has already been sent or not in my eyes. This was already shown in Magento1 and I don't see a reason, why it should not be displayed in Magento2 as well. Do you need any more information regarding this issue from my side?

shikhamis11 commented 4 years ago

@norgeindian this issue is already confirmed and ticket has been created. If you have possible solution for the issue you can create pull request for this issue.

monikav-dckap commented 4 years ago

@magento I am working on this

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

norgeindian commented 3 years ago

@monikav-dckap , any news regarding this issue?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

sprankhub commented 3 years ago

Still relevant :roll_eyes:

petrovsa commented 3 years ago

Screenshot from 2021-05-05 10-41-21 On 2.4-develop. Recheck please

magento-engcom-team commented 3 years ago

Hi @norgeindian.

Thank you for your report and collaboration!

The related internal Jira ticket MC-32976 was closed as non-reproducible in 2.4-develop. It means that Magento team either unable to reproduce this issue using provided Steps to Reproduce from the Description section on clean Magento instance or the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.

norgeindian commented 3 years ago

@petrovsa , your screenshot only provides information about the order confirmation mail. This issue is about the invoice and the information if this has been sent or not. Please be so kind and check again.

petrovsa commented 3 years ago

@norgeindian You are right! Information is absent about the invoice and the information if this has been sent or not

magento-engcom-team commented 3 years ago

Hi @norgeindian.

Thank you for your report and collaboration!

The related internal Jira ticket MC-32976 was closed as non-reproducible in 2.4-develop. It means that Magento team either unable to reproduce this issue using provided Steps to Reproduce from the Description section on clean Magento instance or the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.

norgeindian commented 3 years ago

@petrovsa , thanks for checking. Do you have the possibility to reopen this issue somehow resp. re-open JIRA ticket MC-32976

petrovsa commented 3 years ago

@norgeindian I don`t have possibility to reopen this issue.

norgeindian commented 3 years ago

@dmitriyprime , thanks for trying, but it's still closed...

sdzhepa commented 3 years ago

Reopened due to request from the community. The issue should be reconsidering one more time

norgeindian commented 3 years ago

@sdzhepa , great, thanks a lot. It would be awesome if this could be fixed, as this is a pretty important information for a shop owner....

norgeindian commented 3 years ago

Why is this ticket closed @sdzhepa ? In version 2.4.3 this is still not fixed.

norgeindian commented 3 years ago

@sdzhepa , in my eyes this is still open. Please be so kind and check again

norgeindian commented 3 years ago

@sdzhepa , this is still a bug. Please be so kind and open this ticket again.

sdzhepa commented 3 years ago

Hello @norgeindian

I asked the team to check it and provide details

cc: @engcom-Hotel

engcom-Alfa commented 3 years ago

we are re-opening this issue to cross check again in the 2.4-develop.

m2-assistant[bot] commented 3 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Hotel, here is your Magento Instance: https://38731f93e74494f9cf1bdc574731b28b-2-4-develop.instances.magento-community.engineering Admin access: https://38731f93e74494f9cf1bdc574731b28b-2-4-develop.instances.magento-community.engineering/admin_4090 Login: 4234926c Password: 65aec56d45d1

engcom-Hotel commented 3 years ago

Hello @norgeindian,

The issue is reproducible in the Magento 2.4-develop branch, hence confirming this issue. Please refer below screenshot for reference:

image

Thanks

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/AC-1756 is successfully created for this GitHub issue.

m2-assistant[bot] commented 3 years ago

:white_check_mark: Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

norgeindian commented 2 years ago

@engcom-Hotel , thanks for your feedback. What's the current status of this issue?

norgeindian commented 2 years ago

@engcom-Hotel , any update here?

norgeindian commented 2 years ago

@engcom-Hotel , what's the current status here?

norgeindian commented 2 years ago

@engcom-Hotel , any update on this?

engcom-Hotel commented 2 years ago

Hello @norgeindian,

I will update you on this soon

Thanks

norgeindian commented 2 years ago

@engcom-Hotel , do you have any news for me?

norgeindian commented 2 years ago

@engcom-Hotel , what's the current status here?

engcom-Hotel commented 2 years ago

Hello @norgeindian,

The JIRA ticket is still in process. I will update on this further.

Thanks

topanok commented 2 years ago

@magento I am working on this