Free shipping for physical and virtual products with table rate not working correctly

SteveMcC71 commented 4 years ago

Preconditions (*)

Magento 2.3.4
Magento 2.4-develop

Steps to reproduce (*)

Create table rate file
Stores -> Configuration -> Sales -> Shipping Methods -> Table Rates "Price vs. Destination"
Include Virtual Products in Price Calculation as "No"
Create a Simple Product with price 40$
Create a Virtual Product with price 20$
Navigate to Storefront and add both products to the Cart

Expected result (*)

If a customer adds a physical product AND a virtual or downloadable product to their cart, the cost of the downloadable or virtual product should not be used to calculate the free shipping threshold (in our example 20$)
Shipping price should 20$ according simple product price 40$

Actual result (*)

If we have both a virtual and physical product in our cart and the total value exceeds our threshold of € 20 the shipping is free because it considers both types of product rather than excluding the virtual product from the calculation as expected.
With JUST virtual products in the cart the calculation is correct, or with JUST physical products in cart the calculation is correct.

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-39292 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

magento-engcom-team commented 3 years ago

Hi @SteveMcC71.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39292 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

tsfanning21 commented 1 year ago

Hi @SteveMcC71.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39292 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

I do not believe the scope of this fix was correct. It does not include fixes to the Freeshipping carrier in the module-offline-shipping where the free shipping threshold is calculated. This may be intentional as more than likely any change here would require another configuration setting (I.E. ignore virtual items) but it seems incorrect to assume that virtual items would be included in the free shipping threshold check.

magento / magento2