search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

Probably unnecessary use of `around` plugin #27912

Open lbajsarowicz opened 4 years ago

lbajsarowicz commented 4 years ago

As a part of improving performance and Developer Experience, Magento should reduce the use of around plugins. The ticket mentions some of these, as a "TODO" list to handle in near future.

https://github.com/magento/magento2/blob/b7f6d644399456fda2c12148cc79945aee2ee894/app/code/Magento/Catalog/Model/Indexer/Product/Price/Plugin/CustomerGroup.php#L81-L95

https://github.com/magento/magento2/blob/e60d3a2d8ff3964510ecaa0f7617fa9e482236c4/app/code/Magento/Theme/Model/Indexer/Design/Config/Plugin/Website.php#L36-L44

https://github.com/magento/magento2/blob/e60d3a2d8ff3964510ecaa0f7617fa9e482236c4/app/code/Magento/Theme/Model/Indexer/Design/Config/Plugin/Store.php#L36-L44

https://github.com/magento/magento2/blob/2aebcfb64b863e2b15b357ca6b7b1d07299594b4/app/code/Magento/CatalogSearch/Model/Attribute/SearchWeight.php#L49-L63

https://github.com/magento/magento2/blob/e60d3a2d8ff3964510ecaa0f7617fa9e482236c4/app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Category/Remove.php#L61-L73

https://github.com/magento/magento2/blob/e6bbe78b03eab00f63bba53a65319d1a3c7aeb01/app/code/Magento/ConfigurableProduct/Plugin/Model/ResourceModel/Product.php#L66-L76

Summary (*)

Examples (*)

Proposed solution

m2-assistant[bot] commented 4 years ago

Hi @lbajsarowicz. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

mrtuvn commented 3 years ago

Still may worth investigate on this case

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 28 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

mrtuvn commented 3 years ago

Lol! We are approaching year anniversary of issue

engcom-Bravo commented 1 year ago

Hi @lbajsarowicz,

Thank you for reporting and collaboration.

However it is an existing behaviour of Magento.This is not an issue.

Hence we are considering as Feature Request.

Thanks.