search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

Fixed Price Bundle Products taxed incorrectly under certain circumstances #28051

Closed navarr closed 2 years ago

navarr commented 4 years ago

Preconditions (*)

  1. Magento 2.4
  2. Vertex not installed
  3. entire state of PA configured to be 6% taxable
  4. Customer "Bob Saget" with address: 525 N Allen St State College, PA 16803-3503 USA (any phone number)
  5. Incl/Excl tax display enabled for all fields
  6. "Apply Tax On" configured to "Original price only"

Steps to reproduce (*)

  1. Create a bundle product
  2. Set dyanmic price to No
  3. Set price to $61
  4. Create a required radio option w/ a price of 23 and quantity of 1
  5. Create a required radio option w/ a price of 5 and quantity of 1
  6. Save bundle product
  7. Go to create new order in admin
  8. Select Bob Saget as customer
  9. Add fixed bundle product to order, configured with 1 of each required option and total quantity 3
  10. "Add selected products to order"
  11. Select fixed shipping method

Expected result (*)

  1. Order Grid: Price Excl Tax: $89 Price Incl Tax: $94.34 Subtotal Excl Tax: $267 Subtotal Incl Tax: $283.02
  2. Order Totals Subtotal Excl Tax: $267 Subtotal Incl Tax: $283.02 Tax: $16.02

Actual result (*)

  1. Order Grid: Price Incl Tax: $92.66 Subtotal Incl Tax: $277.98
  2. Order Totals: Subtotal Incl Tax: $277.98 Tax: $10.98
m2-assistant[bot] commented 4 years ago

Hi @navarr. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@navarr do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

m2-assistant[bot] commented 4 years ago

Hi @Mohan2594. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

m2-assistant[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Delta commented 3 years ago

Hi @navarr thank you for your report. Seems like result described in Actual result is not issue, but it is expected result Manual testing scenario:

Result: :heavy_check_mark: Bundle price is correct as tax is 61 0.06 = 3.66: Excl. Tax: $89.00 (61+23+5) Incl. Tax: $92.66 (61+23+5+3.66) :heavy_check_mark: Subtotal is correct as tax for 3 bundle product is 3.66 3=10.98: Excl. Tax: $267.00 (61+25+5) 3 Incl. Tax: $277.98 (61+25+5) 3 + (3 * 3.66) image :heavy_check_mark: Order Totals are correct: Subtotal (Excl. Tax) $267.00 Subtotal (Incl. Tax) $277.98 Grand Total $292.98 image

Could you clarify why such result is not expected(wrong)?

navarr commented 3 years ago

@engcom-Delta: The expectation is that the original price includes the bundle options, the original price being the price the product was before/without a custom price set on it.

So instead of expecting a tax of $3.66, the expectation would be a tax of $5.34

engcom-Delta commented 3 years ago

@navarr I could get price and tax you expect to see when "Apply Tax On" configured toCustom Price if available image image

When "Apply Tax On" configured to Original price only, tax is applied only for bundle price and bundle option's prices are ignored that seems like expected behavior

navarr commented 3 years ago

@engcom-Delta If that expectation is correct, than there is no issue. That was not my expectation.

My expectation would be that configured options are part of the "original price" and that the "custom price" is specifically a custom price provided by an admin in the admin panel.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

navarr commented 3 years ago

This issue is blocked by a definitive answer to the question above,

Chiefly: What is the expectation regarding configured options - are they part of the "original price" of the product, or the "custom price" of the product?

My understanding would be that the "custom price" should ONLY be an overridden price (like by an admin during admin order checkout)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

navarr commented 3 years ago

Blocked awaiting response form Magento

engcom-Delta commented 3 years ago

@magento give me magento 2.4 instance

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 3 years ago

@magento give me magento 2.4 Develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @engcom-Delta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Delta commented 3 years ago

Hi @navarr ,

Issue is not reproducible in Magento 2.4 Develop. Hence closed.

navarr commented 3 years ago

@magento give me magento 2.4 instance

magento-deployment-service[bot] commented 3 years ago

Hi @navarr. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @navarr, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

navarr commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @navarr. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 3 years ago

Hi @navarr, here is your Magento Instance: https://8a4855bcda0bcca482c3e0258789a1eb-2-4-develop.instances.magento-community.engineering Admin access: https://8a4855bcda0bcca482c3e0258789a1eb-2-4-develop.instances.magento-community.engineering/admin_43af Login: 2f9a4c2a Password: c6b74884a422

navarr commented 3 years ago

@engcom-Delta This is still reproducible as described in the issue description.

engcom-Delta commented 2 years ago

Hi @navarr, Verified this issue on Magento 2.4 Develop latest branch. getting different error while "Add selected products to order" at step # 11. Kindly request to confirm the error displayed. Error got ApplyTaxon_precondition Bundle_productCreated quantity_3 OrderTotal OrderTotal

engcom-Delta commented 2 years ago

We have noticed that this issue has not been updated for a period of more than 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.