magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.58k stars 9.32k forks source link

Unlock settings in admin when Magento is in developer mode after we have run magento app: config: dump #28367

Open Hanhan1989 opened 4 years ago

Hanhan1989 commented 4 years ago

Description (*)

I'm talking about the magento 2 pipeline deployment. This way of deploying requires the command magento app:config:dump. After running this command, almost all admin settings are closed and to change any configuration in the development stage, we need to execute other commands such as magento app:config:set

Expected behavior (*)

Unlock all settings in admin when Magento is in developer mode

Benefits

I think it would be much more efficient if we could change the settings from the admin, because it is much more visual. By being more visual, we will make fewer mistakes. otherwise we have to be consulting the path of the configurations and set value.

Additional information

m2-assistant[bot] commented 4 years ago

Hi @Hanhan1989. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

kanevbg commented 3 years ago

Improves the workflow for pipeline deployment strategy

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

dverkade commented 3 years ago

Posting a comment. Issues should not be automatically closed.

hostep commented 3 years ago

Implementing the requested functionality will increase the confusion even more due to the way the priority order works. Because the settings defined in app/etc/config.php file have a higher priority over the settings in the database. So if those fields are enabled in the Magento backend in developer mode, changing them will result in no real changes and it will even be more confusing.

I vote to close this request, unless somebody can come up with a better suggestion to make the configuration easier in developer mode with settings stored in files.

kanevbg commented 3 years ago

@hostep you actually made a progress on the request, I don't believe it should be closed. When settings are unlocked because of mode=developer than the settings should be exported in the config files directly when they are saved. In this case you wont get confusion at all.