[Issue] Cleanup base theme JavaScript modules

m2-assistant[bot] commented 4 years ago

This issue is automatically created based on existing pull request: magento/magento2#27617: Cleanup base theme JavaScript modules

Description (*)

Magento 2.4-develop This PR is a part of my effort to improve Magento 2 frontend performance.

Here I went file by file through the network tab and cleaned-up files that are always loaded by a theme. Changes in this PR include:

responsive.js is completely removed because no code in its contents seems to be valid anymore. Additionally, because it was defined in deps you couldn't even create a mixin for it.
1. product-info-additional can't be found anywhere in the code base so lines 23-33 do nothing.
2. Both mageZoom and mageGallery cannot be found in the code as well (maybe a leftover from M1?). There is mage.zoom widget but it doesn't seem to be imported anywhere.
3. .action.toggle.checkout.progress element doesn't exist in any HTML, PHTML and JS file.
4. checkout-progress-wrapper does not exist.
theme.js is cleaned-up:
1. collapsiblecreate event can't be found in the code base.
2. #store element is not in the code base.
ie-class-fixer is adjusted to be a proper AMD module and uses classList API which IE11 supports anyway.

Expected behavior (*)

Regarding responsive.js and theme.js files nothing should change as code was not applied anyway.
Regarding ie-class-fixer.js, ie11 class should be added to the body on IE11.

Benefits

This PR is a part of my effort to improve Magento 2 frontend performance.

Additional information

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] commented 4 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 4 years ago

@engcom-Delta Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

[ ] Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-35319 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team commented 4 years ago

Hi @m2-assistant[bot]. Thank you for your report. The issue has been fixed in magento/magento2#27617 by @krzksz in 2.4-develop branch Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

magento / magento2