[Issue] Fix shipping address id getter misspelling

m2-assistant[bot] commented 4 years ago

This issue is automatically created based on existing pull request: magento/magento2#28810: Fix shipping address id getter misspelling

Summary (*)

Magento 2.4-develop Fixed a shipping address id getter misspelling in the sales order address save handler. Misspelt getter caused unneeded requests to the database on each order save which might create deadlocks.

Examples (*)

This bug can not be validated manually as there're no effects visible on the front-end. The fix includes Unit tests to validate that address save handler does not execute save attribute method when it's not needed.

Proposed solution

m2-assistant[bot] commented 4 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-35621 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

BassemN commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @BassemN. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @m2-assistant[bot]. Thank you for your report. The issue has been fixed in magento/magento2#28810 by @kodubovik in 2.4-develop branch Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

magento / magento2