PaymentMethod If Discount cancel. When Discount Applies, No Payment

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.49k stars 9.31k forks source link

PaymentMethod If Discount cancel. When Discount Applies, No Payment #29060

Closed vasusundar closed 4 years ago

vasusundar commented 4 years ago

Preconditions (*)

Install Magento 2.3.5
Configure Cart Rule to apply discount in checkout page.
Enable Free Shipping Method and any 2 Payment Method.(COD, Check & Money Order)

Steps to reproduce (*)

Product Total amount is $100. Shipping Method is Free. $0.00
Apply Discount coupon, then No Payment method will display, because total amount is $0.00
Cancel Discount coupon.

Expected result (*)

Discount need to be cancel
Payment Method need to display to proceed place order

Actual result (*)

After Cancel Discount coupon , then loader will show infinity,but in console, there is an error like paymentMethod is null

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @vasusundar. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 4 years ago

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

ajijshekh123 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

ajijshekh123 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

7865fug commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @7865fug. Thank you for your request. I'm working on Magento 2.4-develop instance for you

ajijshekh123 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @ajijshekh123, here is your Magento instance. Admin access: https://i-29060-2-4-develop.instances.magento-community.engineering/admin_5753 Login: cf90c5ca Password: 69eff9871329 Instance will be terminated in up to 3 hours.

ajijshekh123 commented 4 years ago

Hello @vasusundar, I have followed your steps to be reproduced, actual result and expected result but not able to reproduce this issue on Default Magento 2.4 Instance. It is stuck for a few seconds but after a few seconds its working fine. See attached the video and screenshot:

Checkout

Untitled_ Jul 14, 2020 11_21 PM

Thanks.

ajijshekh123 commented 4 years ago

@vasusundar - Any Update. If this issue is fixed Please let me know so I will close this issue.

vasusundar commented 4 years ago

@ajijshekh123 Hope latest version has resolved the issue, but i am getting an issue in Magento2.3.5 Version , Let me recheck in old version

ajijshekh123 commented 4 years ago

Hi... @vasusundar, Please upgrade your Magento Version Or Please verify this issue on Old Magento Version. If this issue reproduced again you can reopen it.

Thanks.

chequille commented 4 years ago

Facing same problem. Will it be fixed in 2.4.x? By the way, do not understand why you let us test things on a 2.4-develop instance. We have the problems on 2.3.5 version. Therefore, is it possible to install a 2.4-develop version on my own server? If yes, let me know.

chequille commented 4 years ago

This is not solved in 2.3.5-p2. Facing the same problem. What the hell is going on?

Owner of the issue, please re-open it.

chequille commented 4 years ago

@vasusundar Hi, it is a shame that such easy things are not solved within 2.3.5-p2. But I tried with the script from 2.4.x and it works as well within 2.3.5-p2. So, the solution is to use select-payment-method-mixins.js from 2.4.x and replace the file in 2.3.5-p2 (I guess as well in 2.3.5-p1). Of course the better way to override it in our theme. Path is Magento_SalesRules/web/js/action It works on my site. Just a personal comment: we have to find the solutions for the bugs ourselves !!!! Regards Chequille

chequille commented 4 years ago

I am sorry, the information above is not 100% correct. It is working if total 0, but if total is not 0 I am getting an error payment method not valid when finishing the order and it is not processed. I am working on this, maybe I find a way.

chequille commented 4 years ago

@vasusundar Hi, sorry for the confusion. The select-payment-method-mixin.js from 2.4.x is working as well with 2.3.5-p2. I had a problem in my own Discount class. So give it a try as I described to solve your problem. Regards Chequille

vasusundar commented 4 years ago

Thanks, It worked by copying that js from Magento 2.4 version.