magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Defined conditions not visible in edit mode for widget Catalog Products List #2913

Closed twiking closed 7 years ago

twiking commented 8 years ago

Steps to repeat

  1. Go to Admin -> Content -> Pages, and edit a page.
  2. Add a new widget to the page
  3. Select Catalog Product Lists as the widget type.
  4. Create a condition
  5. Select Product attribute -> Category
  6. Click on ... and select a category
  7. Insert the widget
  8. Click on "Save and Continue Edit"
  9. Double click on the widget (with WYSIWYG editor mode enabled)

Expected result: The defined conditions should be shown. Actual result: The defined conditions are not shown.

The conditions are saved correctly. Confirmed by looking at the source

{{widget type="Magento\CatalogWidget\Block\Product\ProductsList" title="Product Top List" products_count="10" template="product/widget/content/grid.phtml" conditions_encoded="a:2:[i:1;a:4:[s:4:`type`;s:50:`Magento|CatalogWidget|Model|Rule|Condition|Combine`;s:10:`aggregator`;s:3:`all`;s:5:`value`;s:1:`1`;s:9:`new_child`;s:0:``;]s:4:`1--1`;a:4:[s:4:`type`;s:50:`Magento|CatalogWidget|Model|Rule|Condition|Product`;s:9:`attribute`;s:12:`category_ids`;s:8:`operator`;s:2:`==`;s:5:`value`;s:1:`6`;]]"}}

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36. JS errors: None

shiftedreality commented 8 years ago

@twiking, thank you for reporting!

Internal ticket MAGETWO-47858 was created

facundocapua commented 8 years ago

Is there any update on this issue?

ghost commented 8 years ago

Hi Is there any update on this?

olysenko commented 8 years ago

Hi, this issue is not reproducible(fixed) on develop branch. For now it is all update

wigman commented 8 years ago

Hello @olysenko,

I don't exactly get what you are saying. Is the problem solved in develop branch? I'm currently running Magento CE 2.1.2 in development mode and encounter the same problem.

olysenko commented 8 years ago

@wigman Yes this problem is solved in develop branch, but not in 2.1

wigman commented 8 years ago

@olysenko ok, great. would you happen to know the commit where it was fixed? That way I can cook up a patch. Thanks a lot!

spyrule commented 7 years ago

yes, please post a link to the known commit ... some of us cannot wait for the major patch release.

gabs77 commented 7 years ago

Please, someone know the patch or the commit about that ?

koenner01 commented 7 years ago

Can we please get a commit reference; Like @spyrule said, some of us CANNOT wait for the slow machine of the major releases.

This is a pressing issue and causing real problems for clients.

koenner01 commented 7 years ago

Ok I looked into this further (because we cannot wait on official Magento response) and the commit where this issue is fixed is https://github.com/magento/magento2/commit/49d7b065efa

kanduvisla commented 7 years ago

Any update on this? It still persists in Magento 2.1.4

leptoquark1 commented 7 years ago

Since this has a commit from 6 Jul 2016: When is this gonna be released?

christian-forgacs commented 7 years ago

Not released with Magento 2.1.6...

kishorhase commented 7 years ago

Conditions are actually saved, but does not restored when edit the widget. Any update on this? Issue still persist in Magento ver. 2.1.7

bhargavlalo commented 7 years ago

Yes same issue in Magento ver 2.1.7. Also condition not properly work on frontend. Any update on it?

magento-engcom-team commented 7 years ago

@twiking, thank you for your report. We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue. We tested the issue on 2.3.0-dev, 2.2.0, 2.1.9

christian-forgacs commented 7 years ago

@magento-engcom-team we can confirm, that the issue is fixed in our project with 2.1.9. thank you.