issue with translate-inline

[bohdan-berezhniy]

Preconditions (*)

1. Magento 2.4-develop
2. Disable all shipping methods
3. Create simple product

   Steps to reproduce (*)

4. Go to the Stores -> Configuration -> ADVANCED -> Developer -> Translate Inline -> Enabled for Storefront = Yes
5. Create a new (not English) store view (or use another one if exists)
6. Add simple product to cart
7. Change the store view to the one created in step 2
8. Click on the "Proceed to Checkout" button via mini-cart
9. Go to frontend and create translate for text: "Sorry, no quotes are available for this order at this time". (for example into ukrainian language)
10. Go to the Home page (click on the site Logo)
11. Click on the "View and Edit Cart" button via mini-cart
12. Expand the "Estimate Shipping and Tax" section

Expected result (*)

It`s possible to translate the text

Actual result (*)

It's impossible translate the text

Additional information It happens because in method _loadDbTranslation that in file vendor/magento/framework/Translate.php calls method $data = $this->_translateResource->getTranslationArray(null, $this->getLocale()); that has not set store id and set null as strore id (if we change null on store id - all will works fine)

[m2-assistant[bot]]

Hi @bohdan-berezhniy. Thank you for your report. To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

  :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant[bot]]

Hi @engcom-Lima. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Lima]

Hello @bohdan-berezhniy Could you provide more details for reproduce this issue? Please add version of magento.

Thank you!

[bohdan-berezhniy]

Hello, 2.3.2 Magento version is not important (required version 2 and upper)

ср, 22 лип. 2020 о 15:26 Viktoriia Sekeresh notifications@github.com пише:

Hello @bohdan-berezhniy https://github.com/bohdan-berezhniy Could you provide more details for reproduce this issue? Please add version of magento.

Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/29155#issuecomment-662423483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIAINVJRUA4SZF6OJ2EXTLR43LIDANCNFSM4O2TNGLA .

[engcom-Lima]

Hello @bohdan-berezhniy Could you please add a screenshot of the page that shows this text "Sorry, there are currently no offers for this order.". I mean in the DOM By default it displays as none. But if I change display to block - the text shown. But this invalidate case. So I can't translate it inline

[bohdan-berezhniy]

Hello For me, it happens when I choose a country that not supported by the shipping method. Just remove display none and try to translate that text, or you can adjust the shipping method to get this message.

чт, 23 лип. 2020 о 13:14 Viktoriia Sekeresh notifications@github.com пише:

Hello @bohdan-berezhniy https://github.com/bohdan-berezhniy Could you please add a screenshot of the page that shows this text "Sorry, there are currently no offers for this order.". I mean in the DOM By default it displays as none. [image: Screenshot_51] https://user-images.githubusercontent.com/60198022/88274629-acaf4980-cce4-11ea-8828-09547f1aab2f.png But if I change display to block - the text shown. But this invalidate case. So I can't translate it inline [image: Screenshot_52] https://user-images.githubusercontent.com/60198022/88274772-e8e2aa00-cce4-11ea-929e-92066b16b9b6.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/magento2/issues/29155#issuecomment-662926820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIAINT7NO4FEVRD4NFZPELR5AEQRANCNFSM4O2TNGLA .

[magento-engcom-team]

:white_check_mark: Confirmed by @engcom-Lima Thank you for verifying the issue. Based on the provided information internal tickets MC-36143 were created

Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[magento-engcom-team]

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.

[themew]

Would really like to reopen this issue. There is still no way to translate edit or translate "Sorry, no quotes are available for this order at this time".