Magento 2.4.0 release notification not showing up in backend

hostep commented 4 years ago

Preconditions (*)

Magento 2.4.0 or 2.4.1 or 2.4.2 or 2.4.3 or 2.4.4 or 2.4.5 or 2.4.6 or 2.4.7 or ...

Steps to reproduce (*)

Setup clean 2.4.0 or 2.4.1 or 2.4.2, ... installation, not a 2.4-develop instance! (see reasoning below)
Login to backend (struggle your way through the whole 2FA process rigmarole)

Once finally logged in, seeing a notification at the bottom of the page:

We’ll try to show it again the next time you sign in to Magento Admin.
To learn more about new features, see our latest Release Notes in DevDocs' Release Information

Also notice the strange 'Next >' link in the footer
Logout in backend
Login to backend
Not seeing any release notifications popup

Expected result (*)

Not being confused: if there are release notes for 2.4.0, show them, if there aren't, don't show that We’ll try to show it again ... message

Actual result (*)

Being confused: is there a release notes popup for Magento 2.4.0? If yes, why isn't it showing up? If no, why is that message We’ll try to show it again ... showing up ...

Additional information

https://github.com/magento/magento2/issues/29363#issuecomment-754913283

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[x] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @hostep. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 4 years ago

Hi @engcom-Oscar. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Oscar commented 4 years ago

Hello @hostep

Thank you for your report. Unfortunately, I was not able to reproduce this issue on the latest 2.4 code. Probably it was already fixed and will appear in the next release. Or we missed some steps or preconditions.

Could you please recheck and confirm?

hostep commented 4 years ago

@engcom-Oscar: I'm not sure, I think this release notification window should only pop up in fixed release versions as it is supposed to announce new big features in a new version. I don't think I ever saw it in development versions, so it can't be checked on 2.4-develop I believe, only on 2.4.0 or 2.4.1 (which should already be available as a beta, but I don't have access to the beta versions).

Can you maybe check internally with the architecture team how this thing is supposed to work and why it has this confusing behavior in 2.4.0?

hostep commented 3 years ago

Can still reproduce in a clean 2.4.1 installation.

There is also this weird 'next' link showing up in the footer after a first login into the admin which is part of this thing:

This whole thing is part of the release-notification module, here's the entire html which is rendered on the adminhtml after your first login after a new installation (in case this helps people who look into this issue to know where to start searching):

<div data-bind="scope: 'release_notification.release_notification'" class="entry-edit form-inline">
        <!-- ko template: getTemplate() -->
<!-- ko foreach: {data: elems, as: 'element'} -->
    <!-- ko if: hasTemplate() --><!-- ko template: getTemplate() -->
<div data-bind="css: modalClass, hasFocus: focused" class="modal-component">
    <!-- ko if: state() || $data.modal --><!-- ko foreach: {data: elems, as: 'element'} --><!-- ko template: getTemplate() -->
<div class="fieldset-wrapper" data-bind="visible: $data.visible === undefined ? true: $data.visible, css: $data.additionalClasses, attr: {'data-level': $data.level, 'data-index': index}" data-level="0" data-index="notification_fieldset">
    <!-- ko if: label --><!-- /ko -->

    <div class="admin__fieldset-wrapper-content _hide" data-bind="css: {'admin__collapsible-content': collapsible, '_show': opened, '_hide': !opened()}">
        <!-- ko if: opened() || _wasOpened || initializeFieldsetDataByDefault --><fieldset class="admin__fieldset" data-bind="foreach: {data: elems, as: 'element'}"><!-- ko template: getTemplate() -->

<div class="admin__field-complex release-notification-text" data-bind="css: $data.additionalClasses, attr: {'data-index': index}" data-index="notification_text">

    <!-- ko if: label --><!-- /ko -->

    <div class="admin__field-complex-elements" data-bind="foreach: {data: elems, as: 'element'}"></div>

    <!-- ko if: $data.content --><!-- /ko -->

    <!-- ko if: $data.text --><div class="admin__field-complex-text" data-bind="html: $data.text"><p>We’ll try to show it again the next time you sign in to Magento Admin.</p>
                        <p>To learn more about new features, see our latest Release Notes in
                        <a href="https://devdocs.magento.com/magento-release-information.html" target="_blank">DevDocs' Release Information</a>.
                        </p></div><!-- /ko -->
</div>
<!-- /ko --><!-- ko template: getTemplate() -->
<!-- ko foreach: {data: elems, as: 'element'} -->
    <!-- ko if: hasTemplate() --><!-- ko template: getTemplate() -->
<!-- ko if: visible --><!-- ko template: elementTmpl -->
<button type="button" data-bind="css: buttonClasses, attr: {'data-index': index}, click: action, disable: disabled" class="release-notification-button-next action-additional" data-index="notification_button_next">
    <span data-bind="text: title">Next &gt;</span>
</button>

<!-- ko if: childError --><!-- /ko -->
<!-- /ko --><!-- /ko -->
<!-- /ko --><!-- /ko -->
<!-- /ko -->
<!-- /ko --></fieldset><!-- /ko -->
    </div>
</div>
<!-- /ko --><!-- /ko --><!-- /ko -->
</div>
<!-- /ko --><!-- /ko -->

    <!-- ko if: hasTemplate() --><!-- ko template: getTemplate() -->
<div data-bind="css: modalClass, hasFocus: focused" class="modal-component">
    <!-- ko if: state() || $data.modal --><!-- /ko -->
</div>
<!-- /ko --><!-- /ko -->

    <!-- ko if: hasTemplate() --><!-- ko template: getTemplate() -->
<div data-bind="css: modalClass, hasFocus: focused" class="modal-component">
    <!-- ko if: state() || $data.modal --><!-- /ko -->
</div>
<!-- /ko --><!-- /ko -->

    <!-- ko if: hasTemplate() --><!-- ko template: getTemplate() -->
<div data-bind="css: modalClass, hasFocus: focused" class="modal-component">
    <!-- ko if: state() || $data.modal --><!-- /ko -->
</div>
<!-- /ko --><!-- /ko -->
<!-- /ko -->
<!-- /ko -->
    </div>

This is how the release notification modal used to look back in the days of Magento 2.2.4 for example:

@sidolov: can we have some priorities here? It's most likely an S4 unless you guys feel like release notifications for new versions are actually important? (which they sometimes are I guess)

hostep commented 3 years ago

Confirming that this issue still exists on Magento 2.4.2. It only shows up the very first time you login to the Magento admin.

For the people trying to reproduce, this release notification window only shows up on real Magento releases. Not on some development version from the 2.4-develop or 2.5-develop branch.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

hostep commented 3 years ago

Still happening, not stale, it's not my fault that nobody wants to confirm this ...

magento-engcom-team commented 3 years ago

@engcom-Oscar Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

[ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Oscar Thank you for verifying the issue. Based on the provided information internal tickets MC-41875 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

hostep commented 3 years ago

Confirming that this issue still exists on Magento 2.4.3.

hostep commented 2 years ago

Confirming that this issue still exists on Magento 2.4.4.

hostep commented 2 years ago

Maybe you guys should stop bundling the package magento/module-release-notification in the future, if you plan on no longer using it? Maybe that's the solution for this issue?

hostep commented 2 years ago

Confirming that this issue still exists on Magento 2.4.5.

@sidolov: if Adobe no longer plans on using the release notifications in the future in the backoffice, I would strongly suggest that the magento/module-release-notification package is removed in future versions of Magento, because it has been broken for the last 2 years ... 🙂

github-jira-sync-bot commented 1 year ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-810

hostep commented 8 months ago

Still happens in Magento 2.4.7-beta3, so the deprecation of the Magento_ReleaseNotification module done in AC-9246 was not enough to fix this.

magento / magento2