Open m2-assistant[bot] opened 4 years ago
Hi @engcom-November. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branch@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure. 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.Issue: Confirmed
once verification is complete. Hello @fredden,
Thank you for the report and collaboration!
Going through the PR changes, this issue can be confirmed.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12341 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
This issue is automatically created based on existing pull request: magento/magento2#28715: Use MenuCategoryData to generate array in TopMenu plugin to allow extension via plugins
Description
Following discussion on Magento Community Engineering Slack instance, it has become clear that the
private
methodMagento\Catalog\Plugin\Block\Topmenu::getCategoryAsArray()
should be abstracted to allow extension via plugin (as inheritance (via preference) is to be discouraged). It appears that an existing class provides most of the functionality required. This pull request changesgetCategoryAsArray()
to use this existing external class (withpublic
method) to allow this data to be augmented via plugin on the latter.Related Pull Requests
None known
Fixed Issues
None known
Manual testing scenarios
See also discussion on Slack (link above).
getCategoryAsArray()
from external code (third party extension)Questions or comments
I have not yet adjusted any tests, however this should not result in any change in functionality.
Contribution checklist (*)