magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Activate Tab no longer works on legacy tabs/forms #29892

Closed bvboas closed 4 years ago

bvboas commented 4 years ago

Preconditions (*)

  1. Magento 2.4
  2. Legacy Form with Left Tabs
  3. URL with param: active_tab/TAB_NAME

Steps to reproduce (*)

  1. Create a new record in a form with multiple left tabs
  2. Select one, other than the first left tab
  3. Save the form

Expected result (*)

  1. Users should be redirected back to the form with the previous selected left tab active

Actual result (*)

  1. Users are sent back to the form, and the first left tab is always selected

Media

  1. Video example: https://imgur.com/a/pnb3Gh1

Other Info


m2-assistant[bot] commented 4 years ago

Hi @bvboas. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 4 years ago

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

ajijshekh123 commented 4 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 4 years ago

Hi @ajijshekh123, here is your Magento Instance: https://aab21111c0983fea48aa2ca88b341131-2-4-develop.instances.magento-community.engineering Admin access: https://aab21111c0983fea48aa2ca88b341131-2-4-develop.instances.magento-community.engineering/admin_44ba Login: c0a3a192 Password: 24e666538c52

ajijshekh123 commented 4 years ago

Hi @bvboas, I have verified your issue. This is not an issue. This is a Default Magento Feature. It is not required to redirect on the same tab. Let me close this issue. If you have any query you can reopen this issue/default feature.

Thanks.

bvboas commented 4 years ago

Hi @ajijshekh123 this is most definitely a Magento feature. It has been since version 1.

This bug was introduced by these two commits:

https://github.com/magento/magento2/commit/a3d9095b1352eb585399e7cce850112471955607#diff-926633484bdda3384356b3f61121a4e1

On line 34, the <li> element now has an ID attribute. The problem is that this ID is now duplicated, because the <a>element inside this <li> already has the same ID. And this now leads the "mage/backend/tabs" widget to fail loading the proper element

https://github.com/magento/magento2/commit/82f5a3696c55e65387fc330749e7267dcc269cf1#diff-926633484bdda3384356b3f61121a4e1

Added the CSS class 'no-display',

Please reopen this issue.

Regards,