item layout updates can't remove after add when create new widget

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.56k stars 9.32k forks source link

item layout updates can't remove after add when create new widget #29936

Closed mrtuvn closed 3 years ago

mrtuvn commented 4 years ago

Preconditions (*)

Magento 2.4-develop

Steps to reproduce (*)

Go to admin
Content > Widgets
Add new widget
In section "Layout Updates" Add Layout Update
Try to click on icon basket to remove item

Expected result (*)

Item should be remove

Actual result (*)

Item cannot remove
Only first item could be removed

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[x] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @mrtuvn. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 4 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 4 years ago

@engcom-Delta Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

[ ] Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again. Thanks!

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-37441 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

saphaljha commented 4 years ago

@magento I am working on this issue.

bhaveshpp commented 3 years ago

Magento 2.4

I am facing the same issue in my project. The console is clear there is no error in the console https://drive.google.com/file/d/1EEhxFnAlPUu_-4srQGkQOP_iVtlLxIm6/view

Did anyone found any solution to this issue?

Thank you.

mrtuvn commented 3 years ago

You can see pull request links above

bhaveshpp commented 3 years ago

Hello, It solved my issue. https://github.com/magento/magento2/pull/29991/files Thank you.

bhaveshpp commented 3 years ago

Hello, After applying these file changes my issue with the widget is resolve but this change affects on system config field use system value checkbox

https://github.com/magento/magento2/pull/29991/files

I am facing a new issue in store > Settings > Configuration

https://drive.google.com/file/d/1idssPw1prXYuuIEe7-iKEgSqoA_CSz9S/view

After revert my changes to this file it works fine. lib/internal/Magento/Framework/View/Helper/SecureHtmlRenderer.php

Thank you.

mrtuvn commented 3 years ago

@bhaveshpp this is open PR and not accept yet by magento. You should use patch with caution and maybe this patch fix your problem but will possible break another function in other place We have another PR you can check https://github.com/magento/magento2/pull/30992 (2 PRs in same issue)

magento-engcom-team commented 3 years ago

Hi @mrtuvn. Thank you for your report. The issue has been fixed in magento/magento2#29991 by @saphaljha in 2.4-develop branch Related commit(s):

The fix will be available with the upcoming 2.4.3 release.