[Issue] Inverted attribute grid system column

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.59k stars 9.32k forks source link

[Issue] Inverted attribute grid system column #30235

Open m2-assistant[bot] opened 4 years ago

m2-assistant[bot] commented 4 years ago

This issue is automatically created based on existing pull request: magento/magento2#30227: Inverted attribute grid system column

Description

The Pull Request fixes small issue in product attribute grid Catalog > Products > Product Page > Add Attribute, where System column should be inverted instead displaying as is.

The System grid column is related with is_user_defined column in table, and when is_user_defined = 0 then System should be Yes and vice versa.

Manual testing scenario

Create new product attribute - Stores > Attributes > Product > Add New Attribute
Make sure that in Stores > Attributes > Product grid System column for the newly created attribute displayed as No
Go to any backend product page and open modal attribute grid - Catalog > Products > Product Page > Add Attribute
Make sure that System column is also as No there

The fix has been covered by MFTF test.

m2-assistant[bot] commented 9 months ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
[ ] 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 9 months ago

Hi @elevinskii,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Manual testing scenario

Create new product attribute - Stores > Attributes > Product > Add New Attribute
Make sure that in Stores > Attributes > Product grid System column for the newly created attribute displayed as No
Go to any backend product page and open modal attribute grid - Catalog > Products > Product Page > Add Attribute
Make sure that System column is also as No there

Screenshot from 2024-03-07 12-42-52

Screenshot from 2024-03-07 12-43-33

System column is still yes there.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 9 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-11516 is successfully created for this GitHub issue.

m2-assistant[bot] commented 9 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.