Incorrect currency symbol for surinamese dollar

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

http://www.magento.com

Open Software License 3.0

11.53k stars 9.31k forks source link

Incorrect currency symbol for surinamese dollar #30589

Closed Fuseteam closed 1 day ago

Fuseteam commented 4 years ago

Preconditions (*)

Magento 2.4-develop

Steps to reproduce (*)

set base currency to Suriname Dollar

Expected result (*)

prices on the catalog and the frontend to be prepended with the SRD symbol

Actual result (*)

prices on the catalog and the frontend are prepended with the $ symbol

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[x] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[x] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @Fuseteam. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

bhanu-webkul commented 4 years ago

@Fuseteam Suriname Dollar Currency The Surinamese dollar has been the currency of Suriname since 2004. It is normally abbreviated with the dollar sign $, or alternatively Sr$ to distinguish it from other dollar-denominated currencies. It is divided into 100 cents. Wikipedia Official website: cbvs.sr Symbol: $ Thats why i showing $ this symbol on front end

m2-assistant[bot] commented 4 years ago

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-38657 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Fuseteam commented 4 years ago

@Fuseteam Suriname Dollar Currency The Surinamese dollar has been the currency of Suriname since 2004. It is normally abbreviated with the dollar sign $, or alternatively Sr$ to distinguish it from other dollar-denominated currencies. It is divided into 100 cents. Wikipedia Official website: cbvs.sr Symbol: $ Thats why i showing $ this symbol on front end

i am from suriname we never actually abbreviate as $ or sr$ in practice we abbreviate it as SRD, this is also set by default in magento admin console but i don't see anywhere else but in the configuration section. As shown in the screenshot abbreviating as $ causes confusion if a store decides to put the base currency as surinamese dollar but the display currency as us dollar. As a result it'll say that the total is $71 but they will be charged $1000 which looks and feels scammy lol. yes SRD 1000 is just $71

gabrieldagama commented 4 years ago

@magento I'm working on this

ghost commented 3 years ago

@magento I'm working on this

ghost commented 3 years ago

The solution is remove tick mark below SRD currency and place one space before SRD it will work as per your requirement

Fuseteam commented 3 years ago

i have tested that @Amit-Hariyani and it doesn't change a thing but if even that would work its really just confusing; it says SRD by default so it's should be using SRD not $ in the interface

aasim110 commented 3 years ago

@magento I'm working on this

gabrieldagama commented 3 years ago

Hi @Fuseteam, thanks for reporting this issue.

Just to clarify, regards Wikipedia https://en.wikipedia.org/wiki/Surinamese_dollar the symbol for Surinamese dollar is the same as USD, can you confirm that?

Thank you!

Fuseteam commented 3 years ago

@gabrieldagama as someone living in suriname i can confirm that it does not use $ symbol in practice nor Sr$ we use SRD a couple of examples: https://www.kirpalani.com/nl/apparaten https://www.hsdsonline.com/nl/shop/ https://kev.store/product-category/computers-electronica/ please don't ask me this over and over again I already confirmed this in october i live in suriname if you still doubt me go ask on reddit.com/r/suriname or something

github-jira-sync-bot commented 3 years ago

:x: Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-785

engcom-Bravo commented 1 day ago

Hi @Fuseteam,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the screenshots.

prices on the catalog and the frontend to be prepended with the SRD symbol

Hence we are closing this issue.

Thanks.