Email Template Preview spawns a pop-up window and also directs user away from email templates grid

dvluna commented 4 years ago

Preconditions (*)

Magento 2.4-develop
Both Magento 2.4.0 and 2.4.1
PHP version 7.4.11

Steps to reproduce (*)

Go to Marketing > Communications > Email Templates
Click Add New Template
Fill out the form and save. You'll be sent over to the Email Templates grid.
Click Preview on the newly created Email Template. You'll notice it will pop-up a preview window and also direct the user away from the Email Templates grid to the template preview.

Expected result (*)

Upon clicking Preview, only a preview pop-up window should be displayed. It should not direct the user away from the Email Templates grid. This requires users to click back on the browser to view the Email Templates grid.

Actual result (*)

Upon clicking preview, you'll notice it will pop-up a preview window and also direct the user away from the Email Templates grid to the template preview as shown below. This requires users to click Back on the browser in order to return to the Email Templates grid.

Peek 2020-10-22 13-01

Note: Provided screen shot was generated using Chrome. Firefox creates a new tab instead of a new popup, but experiences the same behavior. Screen Shot 2020-10-21 at 10 37 09 AM

As a note, two separate requests are made upon clicking Preview. The two requests are listed below.
- /admin/email_template/preview/id/1/key/5557c74ad6bc99b53a5b04afa8d26ec457a180e1cc6fdef15ad7e4a88aa1171e/
- /admin/email_template/popup/key/b6de22c72d421f64469acdb1cf2546fbb891babe071c2b509630ce52fef24bfd/

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[x] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 4 years ago

Hi @dvluna. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 4 years ago

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 4 years ago

:white_check_mark: Confirmed by @engcom-Alfa Thank you for verifying the issue. Based on the provided information internal tickets MC-38653 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

amitsamsukha commented 4 years ago

@magento I am working on this

m2-assistant[bot] commented 4 years ago

Hi @amitsamsukha! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

amitsamsukha commented 4 years ago

@magento add to contributors team

m2-assistant[bot] commented 4 years ago

Hi @amitsamsukha! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

amitsamsukha commented 4 years ago

@magento I am working on this

ghost commented 4 years ago

@magento I am working on this

engcom-Bravo commented 5 months ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 5 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 5 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://0e67566b378178dded7a8582ea60aa04.instances-prod.magento-community.engineering Admin access: https://0e67566b378178dded7a8582ea60aa04.instances-prod.magento-community.engineering/admin_a33d Login: 2e97d488 Password: e173eb682f5e

engcom-Bravo commented 5 months ago

Hi @dvluna,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the attached video.

https://github.com/magento/magento2/assets/51680745/8a766d27-d071-4a58-9017-0dad176ed361

It is creating a new tab instead of popup and also direct the user away from the Email Templates grid.

Hence Confirming the issue.

Thanks.

github-jira-sync-bot commented 5 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12040 is successfully created for this GitHub issue.

m2-assistant[bot] commented 5 months ago

:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento / magento2