Closed gwharton closed 3 years ago
Hi @gwharton. Thank you for your report. To help us process this issue please make sure that you provided the following information:
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
@magento give me 2.4-develop instance
- upcoming 2.4.x release
For more details, please, review the Magento Contributor Assistant documentation.
Please, add a comment to assign the issue: @magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
:clock10: You can find the schedule on the Magento Community Calendar page.
:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.
:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel
:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel
Scroll bar visibility being the issue, but can anything be done to improve it.
Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).Details
If the issue has a valid description, the label Issue: Format is valid
will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid
appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description
label to the issue by yourself.
[ ] 3. Add Component: XXXXX
label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop
branchDetails
- Add the comment @magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop
branch, please, add the label Reproduced on 2.4.x
.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed
once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
The same behavior on the latest 2.4-develop. Rechecked with Blank and Luma Themes
:white_check_mark: Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-38805
were created
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
As someone pointed out to me, it is because of scrollbar visibility. Loading a page with content below the fold results in a scroll bar, which shifts the content left slightly when the scrollbar becomes visible. The only way I see round it, is to either a) not have a theme that is page centered...... not gonna happen, or b) use overflow-y to keep scrollbar visible all the time.
maybe some section shift content while rendering that cause problem. That's call Cumulative Layout Shift
This is a non-issue IMO.
Long pages have scrollbars. Short pages do not. That's just how browsers work.
The Luma homepage in the issue description's GIF doesn't have a scrollbar because it's, well, an empty homepage. Once content is added, this issue will be "fixed."
Hi @gwharton, TBH I do agree with @Leland that it's not an issue, but just a default behavior of the browsers which is expected, so we shouldn't fix that.
What do you think about that?
As the original reporter of the issue, I was going to close it as soon as i realised it was a scroll bar issue, however after a bit of thought, I couldnt decide whether it was valid or not.
I understand exactly why it is happening, but..... I dunno, it just feels like the luma theme, in its out of the box format, should present a nice example of a UI which doesn't suffer from the shifting when browsing between pages with and without scroll bars.
Once a site is filled with content, I would expect the vast majority of pages would include below the fold content so would not be an issue, but there will occasionally be a short page somewhere, where a jump is seen.
I'm not gonna die in a ditch about it. I now understand why it is happening. I have implemented always visible scrollbars on my site, because that is my preference, and it only actually affects a very small proportion of my pages, so I am happy, and understand that its probably not right to enforce this policy on everyone who uses Luma as a starting point who may not share my views.
Thanks for the work you put in on the PR @mrtuvn, and apologies if it is deemed no longer required.
Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.
Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop
branch. Thank you for collaboration.
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.