[Issue] Fix wrong format error DHL shipping label

m2-assistant[bot] commented 3 years ago

This issue is automatically created based on existing pull request: magento/magento2#31021: Fix wrong format error DHL shipping label

Fix "The response is in wrong format." error while generating dhl shipping label. When product name has unicode characters substr() is sending � in causing erros dhl syntax errors.

Description (*)

DHL shipping.log produces error "Error in parsing request XML:The element type "PieceContents" must be terminated by the matching end-tag "</PieceContents>"."

This is caused in our use case by substr() not supporting multibyte characters in product name.

Preconditions

Magento 2.4-develop
Magento DHL settings and Store Settings set for USA address
A Customer with a valid United Kingdom address

Steps to reproduce (*)

create a product with product name "Φυστίκι Ψημένο με Αλάτι Συσκευασία"
place an order with dhl shipping method (having debug mode will help trace dhl error response)
try to ship order with "create shipping label" checkbox checked
while requesting label creation you get "The response is in wrong format."

Expected result

Shipping Label should be created

Actual Result

"The response format is wrong" error message appears wrong_format

Note from Engcom :exclamation:

We are able to get the error message with a product named Product

m2-assistant[bot] commented 3 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-39723 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

magento-engcom-team commented 3 years ago

Hi @m2-assistant[bot]. Thank you for your report. The issue has been fixed in magento/magento2#31021 by @vpsnak in 2.4-develop branch Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

magento / magento2