magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.48k stars 9.29k forks source link

Magento 2.4.1 translation issue on admin grids against different locales #31071

Open mobeen-sarwar opened 3 years ago

mobeen-sarwar commented 3 years ago

*Summary ()**

In the scenario of different locales, all admin grids are not translating to the relevant language package. Visit some admin grid like (Admin->sales->transactions) and then change the locale (admin -> Account Settings) to some other locale. Now previously visited admin grid should be translated according to the new locale, but this does not happen.

*Preconditions ()**

1- Magento 2.4.1 2- Magento 2.3.4-p2 3- Magento 2.3.5-p2 4- Translations for at least two locales

  1. Not reproducible on 2.4-develop

*Assumptions()**

1- We are assuming that we have three locales English, Japanese, and Korean, with translations. locales 2- Make sure we have added translations for this path: Admin->Sales->Transactions

*Steps to reproduce ()**

1- Login to Magento admin

2- Go to this path: Admin->Sales->Transactions and note down header translations. This step is a must. To test the translation changes for a grid you must visit it before changing your locale (step 3).

image

3- Now set the Interface Locale to Korean assuming the previous was English US (Go to admin -> Account Settings).

4- Must not flush the cache after changing the locale.

5- Repeat step 2.

*Expected result ()** 1- Grid headers should be translated into Korean.

*Actual result ()** 1- Grid headers are still in English.

transaction-jp

*Further Details()**

1- This translation is also on the below paths: i) Admin->All Customers->Edit (open a customer details)->Reward Points->Reward Points History ii) Admin->Sales->Orders->view(open an order details)->Transactions

2- Video recording of this issue

3- My previous ticket on this issue (magento 2.3.4)

m2-assistant[bot] commented 3 years ago

Hi @mobeen-sarwar. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mobeen-sarwar commented 3 years ago

@magento give me 2.4-develop instance

magento-deployment-service[bot] commented 3 years ago

Hi @mobeen-sarwar. Thank you for your request. I'm working on Magento instance for you.

mobeen-sarwar commented 3 years ago

Hi @engcom-Alfa

I need your support and help here.

Thank you!

magento-deployment-service[bot] commented 3 years ago

Hi @mobeen-sarwar, here is your Magento Instance: https://6a30a9a23463c2dae304b4c097ea9b27-2-4-develop.instances.magento-community.engineering Admin access: https://6a30a9a23463c2dae304b4c097ea9b27-2-4-develop.instances.magento-community.engineering/admin_d17d Login: 78b09f90 Password: a5457ca19a0f

mobeen-sarwar commented 3 years ago

Hi @mobeen-sarwar, here is your Magento Instance: https://6a30a9a23463c2dae304b4c097ea9b27-2-4-develop.instances.magento-community.engineering Admin access: https://6a30a9a23463c2dae304b4c097ea9b27-2-4-develop.instances.magento-community.engineering/admin_d17d Login: 78b09f90 Password: a5457ca19a0f

@magento-deployment-service

This Magento Instance did not have a language pack against different Interface locales.

Thank you!

m2-assistant[bot] commented 3 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 3 years ago

The issue is reproducible on 2.4.1 but not reproducible on the latest 2.4-develop.

magento-engcom-team commented 3 years ago

:white_check_mark: Confirmed by @engcom-Bravo Thank you for verifying the issue. Based on the provided information internal tickets MC-39541 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

mobeen-sarwar commented 3 years ago

@magento I am working on this

m2-assistant[bot] commented 3 years ago

Hi @mobeen-sarwar! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

mobeen-sarwar commented 3 years ago

@magento add to contributors team

m2-assistant[bot] commented 3 years ago

Hi @mobeen-sarwar! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

mobeen-sarwar commented 3 years ago

@magento add to contributors team

mobeen-sarwar commented 3 years ago

@magento I am working on this

engcom-Delta commented 1 month ago

Hi @mobeen-sarwar,

Thanks for your reporting and collaboration. We have verified the issue in latest 2.4-develop instance and it is reproducible. Hence, Confirming the issue.

Steps to reproduce:-

  1. Install Korean Language pack
  2. Create 2 store views
  3. Set locale as "Korean (south korea)"
  4. Create an admin user with Interface locale as "Korean (south korea)
  5. Login with respective admin user
  6. Observe admin menu items are displaying in korean.
  7. Navigate to Admin->Sales->Transactions or Customer > All Customers > Details
  8. Observe grid header is not fully translated, still some content is displaying in english. image image

Thanks.

github-jira-sync-bot commented 1 month ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-12717 is successfully created for this GitHub issue.

m2-assistant[bot] commented 1 month ago

:white_check_mark: Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.