search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.56k stars 9.32k forks source link

Auto generated code needs to be marked as API #32011

Open sivaschenko opened 3 years ago

sivaschenko commented 3 years ago

Description

Auto-generated code needs to be marked as API

Details

  1. Auto generated code needs to be marked as @api:
    1. \Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceFactoryGenerator
    2. \Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceGenerator
    3. \Magento\Framework\Api\Code\Generator\ExtensionAttributesGenerator
    4. \Magento\Framework\MessageQueue\Code\Generator\RemoteServiceGenerator
  2. Factories generated for @api entities must also be marked as @api. Factories for non-@api must not be marked as @api
    1. \Magento\Framework\ObjectManager\Code\Generator\Factory

Testing

Run bin/magento setup:di:compile Check the generated classes

m2-assistant[bot] commented 3 years ago

Hi @sivaschenko. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

DenisSaltanahmedov commented 3 years ago

@magento I am working on this